add gn_all, gyp_all targets to build files, remove GN's //:root

add gn_all, gyp_all targets to the build files, remove GN's //:root

In order to be able to make sure we are building the same list of targets
in both the GYP and GN builds, this patch adds new 'gn_all' and 'gyp_all'
targets.

Eventually, we should make sure that if one builds 'gn_all', then building
'gyp_all', 'All', or 'all' then has nothing to do. We're not there yet, but this
is a start.

The 'gn_all' target replaces the //:root target in the GN builds.

R=brettw@chromium.org
BUG=461019
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg

Committed: https://crrev.com/ff30e3de333305ccdaa103aa7f9e46765da83e99
Cr-Commit-Position: refs/heads/master@{#317760}

[Dirk Pranke, 2015-02-21 02:10:08]

dpranke@chromium.org changed reviewers:
+ brettw@chromium.org

[brettw, 2015-02-23 18:36:21]

lgtm

https://codereview.chromium.org/936193004/diff/140001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/936193004/diff/140001/BUILD.gn#newcode11
BUILD.gn:11: import("//build/config/features.gni")
Sadness... oh well. We can optimize this later if necessary (this basically
blocks the entire GN run on synchronously loading this file).

https://codereview.chromium.org/936193004/diff/140001/BUILD.gn#newcode308
BUILD.gn:308: group("gyp_all") {
I don't have a strong objection to this, but it seems weird to me. Why not just
put these targets in the list below with the TODO(GYP) comment? It seems like
this target will only ever have one uncommented dependency on gn_all.

https://codereview.chromium.org/936193004/diff/140001/build/secondary/tools/g...
File build/secondary/tools/grit/grit_rule.gni (right):

https://codereview.chromium.org/936193004/diff/140001/build/secondary/tools/g...
build/secondary/tools/grit/grit_rule.gni:59: #   visibility  (optional)
configs should be documented here. Be sure to make clear that it's additive to
the default list of configs set when compiling the sources.

[Dirk Pranke, 2015-02-23 19:17:43]

https://codereview.chromium.org/936193004/diff/140001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/936193004/diff/140001/BUILD.gn#newcode11
BUILD.gn:11: import("//build/config/features.gni")
On 2015/02/23 18:36:21, brettw wrote:
> Sadness... oh well. We can optimize this later if necessary (this basically
> blocks the entire GN run on synchronously loading this file).

Yeah ...

https://codereview.chromium.org/936193004/diff/140001/BUILD.gn#newcode308
BUILD.gn:308: group("gyp_all") {
On 2015/02/23 18:36:21, brettw wrote:
> I don't have a strong objection to this, but it seems weird to me. Why not
just
> put these targets in the list below with the TODO(GYP) comment? It seems like
> this target will only ever have one uncommented dependency on gn_all.

Yes. Mostly it exists for symmetry w/ gyp_all, but this is arguably pointless,
as you say.

Mostly I hope to kill off gyp_all in both GN and GYP builds pretty quickly.

https://codereview.chromium.org/936193004/diff/140001/build/secondary/tools/g...
File build/secondary/tools/grit/grit_rule.gni (right):

https://codereview.chromium.org/936193004/diff/140001/build/secondary/tools/g...
build/secondary/tools/grit/grit_rule.gni:59: #   visibility  (optional)
On 2015/02/23 18:36:21, brettw wrote:
> configs should be documented here. Be sure to make clear that it's additive to
> the default list of configs set when compiling the sources.

Good catch. Will do.

[Dirk Pranke, 2015-02-23 19:17:57]

The CQ bit was checked by dpranke@chromium.org

[Dirk Pranke, 2015-02-23 19:18:04]

The CQ bit was unchecked by dpranke@chromium.org

[Dirk Pranke, 2015-02-23 19:51:04]

The CQ bit was checked by dpranke@chromium.org

[Dirk Pranke, 2015-02-23 19:51:04]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/936193004/#ps160001
(title: "merge to #317624")

[commit-bot: I haz the power, 2015-02-23 19:52:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/936193004/160001

[commit-bot: I haz the power, 2015-02-23 20:11:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-23 20:11:02]

Try jobs failed on following builders:
  ios_rel_device_ninja_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[Dirk Pranke, 2015-02-23 20:41:51]

The CQ bit was checked by dpranke@chromium.org

[commit-bot: I haz the power, 2015-02-23 20:42:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/936193004/160001

[commit-bot: I haz the power, 2015-02-23 21:04:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-23 21:04:41]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Dirk Pranke, 2015-02-23 21:58:44]

The CQ bit was checked by dpranke@chromium.org

[Dirk Pranke, 2015-02-23 21:58:45]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/936193004/#ps180001
(title: "fix gyp targets, remove //:root")

[commit-bot: I haz the power, 2015-02-23 21:59:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/936193004/180001

[commit-bot: I haz the power, 2015-02-23 22:05:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-23 22:05:46]

Try jobs failed on following builders:
  android_aosp on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)

[Dirk Pranke, 2015-02-23 22:12:58]

The CQ bit was checked by dpranke@chromium.org

[Dirk Pranke, 2015-02-23 22:12:59]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/936193004/#ps200001
(title: "merge to #317661")

[commit-bot: I haz the power, 2015-02-23 22:14:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/936193004/200001

[Dirk Pranke, 2015-02-23 22:26:19]

The CQ bit was unchecked by dpranke@chromium.org

[Dirk Pranke, 2015-02-23 22:32:05]

The CQ bit was checked by dpranke@chromium.org

[Dirk Pranke, 2015-02-23 22:32:06]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/936193004/#ps220001
(title: "move gyp_all, gn_all into OS!=iOS block in all.gyp")

[commit-bot: I haz the power, 2015-02-23 22:39:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/936193004/220001

[commit-bot: I haz the power, 2015-02-23 23:20:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-23 23:20:09]

Try jobs failed on following builders:
  android_rel_tests_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_rel_tes...)

[Dirk Pranke, 2015-02-23 23:30:43]

The CQ bit was checked by dpranke@chromium.org

[Dirk Pranke, 2015-02-23 23:30:44]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/936193004/#ps230001
(title: "disable html_viewer_unittests, device_unittests,
google_apis_unittests")

[commit-bot: I haz the power, 2015-02-23 23:31:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/936193004/230001

[Dirk Pranke, 2015-02-24 00:07:48]

The CQ bit was checked by dpranke@chromium.org

[Dirk Pranke, 2015-02-24 00:07:49]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/936193004/#ps250001
(title: "merge to #317682, add codesighs and bitmaptools")

[commit-bot: I haz the power, 2015-02-24 00:07:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/936193004/250001

[commit-bot: I haz the power, 2015-02-24 00:38:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-24 00:38:17]

Try jobs failed on following builders:
  win8_chromium_gn_rel on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_gn_...)

[Dirk Pranke, 2015-02-24 00:46:11]

Patchset #15 (id:270001) has been deleted

[Dirk Pranke, 2015-02-24 00:46:17]

The CQ bit was checked by dpranke@chromium.org

[Dirk Pranke, 2015-02-24 00:46:17]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/936193004/#ps290001
(title: "merge to #317694, disable device and google_api unit tests in gn_all")

[commit-bot: I haz the power, 2015-02-24 00:47:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/936193004/290001

[Dirk Pranke, 2015-02-24 00:55:34]

The CQ bit was unchecked by dpranke@chromium.org

[Dirk Pranke, 2015-02-24 05:37:56]

The CQ bit was checked by dpranke@chromium.org

[Dirk Pranke, 2015-02-24 05:37:57]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/936193004/#ps350001
(title: "temporarily disable gn_all and gyp_all on Android")

[commit-bot: I haz the power, 2015-02-24 05:38:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/936193004/350001

[commit-bot: I haz the power, 2015-02-24 06:52:47]

Committed patchset #18 (id:350001)

[commit-bot: I haz the power, 2015-02-24 06:53:38]

Patchset 18 (id:??) landed as
https://crrev.com/ff30e3de333305ccdaa103aa7f9e46765da83e99
Cr-Commit-Position: refs/heads/master@{#317760}

[hiroshige, 2015-02-24 07:41:03]

A revert of this CL (patchset #18 id:350001) has been created in
https://codereview.chromium.org/944573003/ by hiroshige@chromium.org.

The reason for reverting is: Suspecting this breaks Mac builds.
http://build.chromium.org/p/chromium/builders/Mac/builds/33993.

[hiroshige, 2015-02-24 08:15:34]

The revert of this CL is landed and the revert CL (r317763) turned Mac bots
green:

r317762:
http://build.chromium.org/p/chromium/builders/Mac/builds/33994
http://build.chromium.org/p/chromium.webkit/builders/Mac10.8%20Tests/builds/1...

r317763:
http://build.chromium.org/p/chromium/builders/Mac/builds/33995
http://build.chromium.org/p/chromium.webkit/builders/Mac10.8%20Tests/builds/1...

[gunsch, 2015-02-24 08:24:26]

gunsch@chromium.org changed reviewers:
+ gunsch@chromium.org

[gunsch, 2015-02-24 08:24:27]

I know it's been reverted, but one comment on an Ozone dep that separately broke
a Chromecast trybot

https://codereview.chromium.org/936193004/diff/350001/build/all.gyp
File build/all.gyp (right):

https://codereview.chromium.org/936193004/diff/350001/build/all.gyp#newcode596
build/all.gyp:596: '../ui/ozone/demo.gyp:demo',
This target doesn't exist?

[Dirk Pranke, 2015-02-24 15:48:05]

On 2015/02/24 08:24:27, gunsch wrote:
> I know it's been reverted, but one comment on an Ozone dep that separately
broke
> a Chromecast trybot
> 
> https://codereview.chromium.org/936193004/diff/350001/build/all.gyp
> File build/all.gyp (right):
> 
> https://codereview.chromium.org/936193004/diff/350001/build/all.gyp#newcode596
> build/all.gyp:596: '../ui/ozone/demo.gyp:demo',
> This target doesn't exist?

@gunsch: thanks for pointing that out, I'll fix that along w/ the other aura
issue.