Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 936173002: Rename LocalDataPipe -> LocalDataPipeImpl. (Closed)

Created:
5 years, 10 months ago by viettrungluu
Modified:
5 years, 10 months ago
Reviewers:
yzshen1
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Rename LocalDataPipe -> LocalDataPipeImpl. This seems a little strange, but it's a step towards the following: * LocalDataPipeImpl will subclass/implement DataPipeImpl (to be introduced) instead of DataPipe. * DataPipe will have a DataPipeImpl member (instead of being subclassed). * This allows a DataPipe's impl to be swapped out for a different one (e.g., a cross-process one). (A DataPipe itself is hard to swap out, since Dispatchers have references to it.) R=yzshen@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/075efe912b678657ab4130999368c70eee2365e9

Patch Set 1 #

Patch Set 2 : rebase on top of https://codereview.chromium.org/936283002/ #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -2645 lines) Patch
M mojo/edk/system/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/edk/system/core.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D mojo/edk/system/local_data_pipe.h View 1 chunk +0 lines, -105 lines 0 comments Download
D mojo/edk/system/local_data_pipe.cc View 1 1 chunk +0 lines, -388 lines 0 comments Download
A + mojo/edk/system/local_data_pipe_impl.h View 3 chunks +10 lines, -9 lines 0 comments Download
A + mojo/edk/system/local_data_pipe_impl.cc View 1 20 chunks +24 lines, -24 lines 0 comments Download
A + mojo/edk/system/local_data_pipe_impl_unittest.cc View 38 chunks +55 lines, -43 lines 0 comments Download
D mojo/edk/system/local_data_pipe_unittest.cc View 1 chunk +0 lines, -2071 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
viettrungluu
5 years, 10 months ago (2015-02-18 18:48:18 UTC) #1
viettrungluu
(Now dependent on https://codereview.chromium.org/936173002/.)
5 years, 10 months ago (2015-02-18 23:34:07 UTC) #2
viettrungluu
On 2015/02/18 23:34:07, viettrungluu wrote: > (Now dependent on https://codereview.chromium.org/936173002/.) I meant https://codereview.chromium.org/936283002/.
5 years, 10 months ago (2015-02-18 23:34:45 UTC) #3
yzshen1
lgtm
5 years, 10 months ago (2015-02-19 18:02:03 UTC) #4
viettrungluu
5 years, 10 months ago (2015-02-19 18:35:00 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
075efe912b678657ab4130999368c70eee2365e9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698