Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 936163003: Add GN for sandbox_linux_jni_unittests (Closed)

Created:
5 years, 10 months ago by Ken Rockot(use gerrit already)
Modified:
5 years, 10 months ago
CC:
chromium-reviews, rickyz+watch_chromium.org, jln+watch_chromium.org, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add GN for sandbox_linux_jni_unittests BUG= Committed: https://crrev.com/86da06c7f5925e582a481a5c87fe477edd80944f Cr-Commit-Position: refs/heads/master@{#317445}

Patch Set 1 #

Patch Set 2 : comment #

Patch Set 3 : fix android #

Total comments: 1

Patch Set 4 : now with less redundancy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -19 lines) Patch
M sandbox/linux/BUILD.gn View 1 2 3 2 chunks +22 lines, -19 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
Ken Rockot(use gerrit already)
Julienne, please take a look. +Dirk CC FYI
5 years, 10 months ago (2015-02-19 02:10:49 UTC) #2
jln (very slow on Chromium)
Not an expert, but lgtm. Thanks for doing this!
5 years, 10 months ago (2015-02-20 03:21:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/936163003/20001
5 years, 10 months ago (2015-02-20 03:43:46 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/44104)
5 years, 10 months ago (2015-02-20 03:48:55 UTC) #7
Ken Rockot(use gerrit already)
+brettw for toplevel GN
5 years, 10 months ago (2015-02-20 03:50:23 UTC) #9
brettw
https://codereview.chromium.org/936163003/diff/40001/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/936163003/diff/40001/BUILD.gn#newcode75 BUILD.gn:75: "//sandbox/linux:sandbox_linux_jni_unittests", I don't think you need to add this ...
5 years, 10 months ago (2015-02-20 23:05:49 UTC) #11
Ken Rockot(use gerrit already)
oh, word. thanks
5 years, 10 months ago (2015-02-20 23:08:32 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/936163003/60001
5 years, 10 months ago (2015-02-20 23:15:06 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-21 00:41:05 UTC) #15
commit-bot: I haz the power
5 years, 10 months ago (2015-02-21 00:41:30 UTC) #16
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/86da06c7f5925e582a481a5c87fe477edd80944f
Cr-Commit-Position: refs/heads/master@{#317445}

Powered by Google App Engine
This is Rietveld 408576698