Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 936143003: Start to use new metadata item in ImageEncoder. (Closed)

Created:
5 years, 10 months ago by hirono
Modified:
5 years, 10 months ago
Reviewers:
yawano
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Start to use new metadata item in ImageEncoder. BUG=410766 TEST=None Committed: https://crrev.com/4d57cb47d889a6c248027fe7039f5af6300dfc0d Cr-Commit-Position: refs/heads/master@{#318188}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fixed. #

Patch Set 3 : Fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -179 lines) Patch
M ui/file_manager/gallery/js/gallery_item.js View 1 1 chunk +32 lines, -27 lines 0 comments Download
M ui/file_manager/gallery/js/gallery_item_unittest.js View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M ui/file_manager/gallery/js/image_editor/exif_encoder.js View 1 8 chunks +55 lines, -45 lines 0 comments Download
M ui/file_manager/gallery/js/image_editor/exif_encoder_unittest.js View 1 2 chunks +43 lines, -45 lines 0 comments Download
M ui/file_manager/gallery/js/image_editor/image_encoder.js View 8 chunks +45 lines, -50 lines 0 comments Download
M ui/file_manager/gallery/js/image_editor/image_encoder_unittest.js View 4 chunks +4 lines, -12 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
hirono
PTAL the CL. Thanks!
5 years, 10 months ago (2015-02-25 08:47:42 UTC) #2
yawano
Thank you! https://codereview.chromium.org/936143003/diff/1/ui/file_manager/gallery/js/image_editor/exif_encoder.js File ui/file_manager/gallery/js/image_editor/exif_encoder.js (right): https://codereview.chromium.org/936143003/diff/1/ui/file_manager/gallery/js/image_editor/exif_encoder.js#newcode17 ui/file_manager/gallery/js/image_editor/exif_encoder.js:17: * @type {!Object} nit: @type -> @private ...
5 years, 10 months ago (2015-02-25 09:19:10 UTC) #3
hirono
https://codereview.chromium.org/936143003/diff/1/ui/file_manager/gallery/js/image_editor/exif_encoder.js File ui/file_manager/gallery/js/image_editor/exif_encoder.js (right): https://codereview.chromium.org/936143003/diff/1/ui/file_manager/gallery/js/image_editor/exif_encoder.js#newcode17 ui/file_manager/gallery/js/image_editor/exif_encoder.js:17: * @type {!Object} On 2015/02/25 09:19:10, yawano wrote: > ...
5 years, 10 months ago (2015-02-25 13:28:37 UTC) #4
yawano
lgtm. Thank you!
5 years, 10 months ago (2015-02-26 03:31:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/936143003/40001
5 years, 10 months ago (2015-02-26 03:38:35 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-26 05:05:39 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 05:06:28 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/4d57cb47d889a6c248027fe7039f5af6300dfc0d
Cr-Commit-Position: refs/heads/master@{#318188}

Powered by Google App Engine
This is Rietveld 408576698