Issue 936133003: Fixing possible out of bound memory access

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 936133003: Fixing possible out of bound memory access (Closed)

Created:
5 years, 10 months ago by sugoi1

Modified:
5 years, 10 months ago

Reviewers:
scroggo, reed2

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Fixing possible out of bound memory access This was a bug found by ASAN. When width is very small, we can have something like width == 1 and rowBytes == 8. Using "2 * yWidth" (2) would be smaller than rowBytesY (8), so we could read memory out of bounds. This issue has a separate fix in blink (crbug.com/458861). BUG=skia: Committed: https://skia.googlesource.com/skia/+/f421ec6cc9c8f32d717b9b1df71fd9e79817a16c

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	src/images/SkImageDecoder_libjpeg.cpp	View		1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/936133003/1

5 years, 10 months ago (2015-02-19 13:26:14 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-02-19 13:32:15 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f421ec6cc9c8f32d717b9b1df71fd9e79817a16c

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages