Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 9361076: roll gyp 1195:1201 (Closed)

Created:
8 years, 10 months ago by Nico
Modified:
8 years, 10 months ago
Reviewers:
M-A Ruel, scottmg
CC:
chromium-reviews
Visibility:
Public.

Description

roll gyp 1195:1201 1196: Make dump_dependency_json work on windows. 1197: mac make&ninja: Support GCC_CHAR_IS_UNSIGNED_CHAR. 1198: mac make&ninja: Support ARCHS with zero or one element. 1199: scottmg can't handle svn. 1200: Very preliminary work for ninja on Windows. 1201: Revert 1199. BUG=none TEST=none TBR=scottmg Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=122032

Patch Set 1 #

Patch Set 2 : 1201 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Nico
8 years, 10 months ago (2012-02-15 00:42:36 UTC) #1
scottmg
lgtm
8 years, 10 months ago (2012-02-15 00:44:25 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 10 months ago (2012-02-15 00:45:37 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 10 months ago (2012-02-15 00:45:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/9361076/3001
8 years, 10 months ago (2012-02-15 00:47:00 UTC) #5
M-A Ruel
lgtm
8 years, 10 months ago (2012-02-15 00:53:16 UTC) #6
commit-bot: I haz the power
Try job failure for 9361076-3001 (retry) on linux_rel for step "compile" (clobber build). It's a ...
8 years, 10 months ago (2012-02-15 01:23:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/9361076/3001
8 years, 10 months ago (2012-02-15 01:25:47 UTC) #8
commit-bot: I haz the power
8 years, 10 months ago (2012-02-15 04:12:31 UTC) #9
Change committed as 122032

Powered by Google App Engine
This is Rietveld 408576698