Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(928)

Unified Diff: content/browser/indexed_db/leveldb/leveldb_database.cc

Issue 936073003: Remove unused errno parsing for leveldb status codes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: FILE_OK -> FILE_ERROR_MAX Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/leveldatabase/env_chromium.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/indexed_db/leveldb/leveldb_database.cc
diff --git a/content/browser/indexed_db/leveldb/leveldb_database.cc b/content/browser/indexed_db/leveldb/leveldb_database.cc
index 51a8aea827771978a8875bce9728a63bb5712a4a..aab1255d145a6e46d3f64e9a602365c9156d5d15 100644
--- a/content/browser/indexed_db/leveldb/leveldb_database.cc
+++ b/content/browser/indexed_db/leveldb/leveldb_database.cc
@@ -183,7 +183,7 @@ static int CheckFreeSpace(const char* const type,
static void ParseAndHistogramIOErrorDetails(const std::string& histogram_name,
const leveldb::Status& s) {
leveldb_env::MethodID method;
- int error = -1;
+ base::File::Error error = base::File::FILE_OK;
leveldb_env::ErrorParsingResult result =
leveldb_env::ParseMethodAndError(s, &method, &error);
if (result == leveldb_env::NONE)
@@ -209,15 +209,6 @@ static void ParseAndHistogramIOErrorDetails(const std::string& histogram_name,
-base::File::FILE_ERROR_MAX,
-base::File::FILE_ERROR_MAX + 1,
base::HistogramBase::kUmaTargetedHistogramFlag)->Add(-error);
- } else if (result == leveldb_env::METHOD_AND_ERRNO) {
- error_histogram_name.append(std::string(".Errno.") +
- leveldb_env::MethodIDToString(method));
- base::LinearHistogram::FactoryGet(
- error_histogram_name,
- 1,
- ERANGE + 1,
- ERANGE + 2,
- base::HistogramBase::kUmaTargetedHistogramFlag)->Add(error);
}
}
« no previous file with comments | « no previous file | third_party/leveldatabase/env_chromium.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698