Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 936033003: fix xcode build (Closed)

Created:
5 years, 10 months ago by mtklein_C
Modified:
5 years, 10 months ago
Reviewers:
hal.canary, mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

fix xcode build NOTREECHECKS=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/4c7a8b04a09a6b9558a8ffcfbd311c0681ab5df1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M gyp/zlib.gyp View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
mtklein
5 years, 10 months ago (2015-02-18 14:46:55 UTC) #2
reed1
5 years, 10 months ago (2015-02-18 14:57:58 UTC) #4
hal.canary
lgtm, if it works for reed@
5 years, 10 months ago (2015-02-18 14:59:38 UTC) #5
reed1
this one works too.
5 years, 10 months ago (2015-02-18 15:01:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/936033003/1
5 years, 10 months ago (2015-02-18 15:08:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/936033003/1
5 years, 10 months ago (2015-02-18 17:35:37 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-18 17:35:55 UTC) #12
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/4c7a8b04a09a6b9558a8ffcfbd311c0681ab5df1

Powered by Google App Engine
This is Rietveld 408576698