Issue 936033002: Replace custom implementation of ObjectProtoToString with call to builtin

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 936033002: Replace custom implementation of ObjectProtoToString with call to builtin

Created:
5 years, 10 months ago by yurys

Modified:
5 years, 10 months ago

Reviewers:
fqian, Dmitry Lomov (no reviews)

CC:
v8-dev, aandrey

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

Replace custom implementation of ObjectProtoToString with call to builtin The implementation in api.cc seems to just repeat what is written in v8natives.js and harmony-tostring.js I replaced it with call to the corresponding builtin. BUG=None LOG=N

Patch Set 1 : #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -58 lines)			Patch
	M	src/api.cc	View		1 chunk	+30 lines, -58 lines	0 comments	Download

Messages

Total messages: 5 (4 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

yurys

5 years, 10 months ago (2015-02-18 12:15:38 UTC) #2

@fqian: my understanding is that this change shouldn't regress Blink
implementation of V8Window::toStringMethodCustom [1]. Please confirm that as you
are the author of the FIXME comment for that code.

[1]
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages