Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 93603008: GTTF: Include info about disabled tests and platforms in JSON test summary. (Closed)

Created:
6 years, 11 months ago by Paweł Hajdan Jr.
Modified:
6 years, 11 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

GTTF: Include info about disabled tests and platforms in JSON test summary. This will make it possible to analyze which tests are disabled on specific platforms, and whether the failures are really platform-specific. Including list of all tests in the summary makes it possible to e.g. detect when a test first appeared (or disappeared), which platforms a test is compiled on, or whether some tests have been filtered out. BUG=236893 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243232

Patch Set 1 #

Total comments: 4

Patch Set 2 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -4 lines) Patch
M base/test/launcher/test_launcher.cc View 1 3 chunks +71 lines, -4 lines 0 comments Download
M base/test/launcher/test_results_tracker.h View 2 chunks +13 lines, -0 lines 0 comments Download
M base/test/launcher/test_results_tracker.cc View 1 4 chunks +37 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Paweł Hajdan Jr.
6 years, 11 months ago (2014-01-06 11:12:17 UTC) #1
sky
LGTM https://codereview.chromium.org/93603008/diff/1/base/test/launcher/test_launcher.cc File base/test/launcher/test_launcher.cc (right): https://codereview.chromium.org/93603008/diff/1/base/test/launcher/test_launcher.cc#newcode688 base/test/launcher/test_launcher.cc:688: #ifdef NDEBUG nit: #if defined(NDEBUG) https://codereview.chromium.org/93603008/diff/1/base/test/launcher/test_results_tracker.cc File base/test/launcher/test_results_tracker.cc ...
6 years, 11 months ago (2014-01-06 19:24:15 UTC) #2
Paweł Hajdan Jr.
https://codereview.chromium.org/93603008/diff/1/base/test/launcher/test_launcher.cc File base/test/launcher/test_launcher.cc (right): https://codereview.chromium.org/93603008/diff/1/base/test/launcher/test_launcher.cc#newcode688 base/test/launcher/test_launcher.cc:688: #ifdef NDEBUG On 2014/01/06 19:24:15, sky wrote: > nit: ...
6 years, 11 months ago (2014-01-07 09:12:27 UTC) #3
Paweł Hajdan Jr.
6 years, 11 months ago (2014-01-07 09:26:29 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r243232.

Powered by Google App Engine
This is Rietveld 408576698