Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Unified Diff: components/translate/README

Issue 93603006: Move Translate-related files to components/translate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/translate.gypi ('k') | components/translate/common/translate_constants.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/translate/README
diff --git a/components/translate/README b/components/translate/README
index 076afe91f87bb71b9aec81c521aef8f454bdad61..f5f2e4c8e760f75843dd7c717c816886d5021aca 100644
--- a/components/translate/README
+++ b/components/translate/README
@@ -1,8 +1,19 @@
- translate/language detection depends on the CLD library and should only be
used from the renderer to avoid bloating the DLLs on Windows.
-- Translate is not allowed to depend on content/, because it is used by iOS.
-If dependences on content/ need to be added to Translate, it will have to be
-made into a layered component: see
-http://www.chromium.org/developers/design-documents/layered-components-design
-for more information.
+- Translate is in the process of becoming a layered component
+(https://sites.google.com/a/chromium.org/dev/developers/design-documents/layered-components-design)
+to enable it to be shared cleanly on iOS.
+
+When this process is complete, this component will have the following structure:
+
+core/: shared code that does not depend on src/content/ or src/ios/
+ browser/: Browser process code
+ common/: Code shared by the browser and the renderer
+ language_detection/: Language detection code, only used from the renderer on
+ all platforms but iOS (where it is used from the browser)
+content/: Driver for the shared code based on the content layer.
+ browser/: Browser process code.
+ renderer/: Renderer process code.
+ common/: Code shared by the browser and the renderer.
+ios/: Driver for the shared code based on src/ios.
« no previous file with comments | « components/translate.gypi ('k') | components/translate/common/translate_constants.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698