components/translate.gypi - Issue 93603006: Move Translate-related files to components/translate

Unified Diff: components/translate.gypi

Issue 93603006: Move Translate-related files to components/translate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: alphabetize BUILD.gn Created 6 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/translate.gypi

diff --git a/components/translate.gypi b/components/translate.gypi

index 7c19fe81bdb0c505f11e71b113c76df0efb4a7dc..76716fe800c9ca6936ff10a379bbfe37a462f213 100644

--- a/components/translate.gypi

+++ b/components/translate.gypi

@@ -5,7 +5,7 @@

{

'targets': [

{

- 'target_name': 'translate_common',

+ 'target_name': 'translate_core_browser',

'type': 'static_library',

'dependencies': [

'../base/base.gyp:base',

blundell 2014/01/06 12:04:52 Should this depend on translate_core_common?

droger 2014/01/06 13:21:31 Yes. Done.

@@ -15,21 +15,41 @@

'..',

'sources': [

- 'translate/common/translate_constants.cc',

- 'translate/common/translate_constants.h',

- 'translate/common/translate_metrics.cc',

- 'translate/common/translate_metrics.h',

- 'translate/common/translate_switches.cc',

- 'translate/common/translate_switches.h',

- 'translate/common/translate_util.cc',

- 'translate/common/translate_util.h',

+ 'translate/core/browser/page_translated_details.h',

+ 'translate/core/browser/translate_error_details.h',

blundell 2014/01/06 12:04:52 This file is duplicated below.

droger 2014/01/06 13:21:31 No, it's slightly different ("event" instead of "e

+ 'translate/core/browser/translate_event_details.cc',

+ 'translate/core/browser/translate_event_details.h',

+ ],

+ },

+ {

+ 'target_name': 'translate_core_common',

+ 'type': 'static_library',

+ 'dependencies': [

+ '../base/base.gyp:base',

+ '../url/url.gyp:url_lib',

+ ],

+ 'include_dirs': [

+ '..',

+ ],

+ 'sources': [

+ 'translate/core/common/translate_constants.cc',

+ 'translate/core/common/translate_constants.h',

+ 'translate/core/common/translate_errors.h',

+ 'translate/core/common/translate_metrics.cc',

+ 'translate/core/common/translate_metrics.h',

+ 'translate/core/common/translate_switches.cc',

+ 'translate/core/common/translate_switches.h',

+ 'translate/core/common/translate_util.cc',

+ 'translate/core/common/translate_util.h',

+ 'translate/core/common/language_detection_details.cc',

+ 'translate/core/common/language_detection_details.h',

{

'target_name': 'translate_language_detection',

'type': 'static_library',

'dependencies': [

- 'translate_common',

+ 'translate_core_common',

'../base/base.gyp:base',

'../url/url.gyp:url_lib',

« components/components_tests.gyp ('K') | « components/components_tests.gyp ('k') | components/translate/common/translate_constants.h » ('j') | no next file with comments »