Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Unified Diff: tools/gn/secondary/components/translate/BUILD.gn

Issue 93603006: Move Translate-related files to components/translate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix include order Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/translate/language_detection/language_detection_util_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/secondary/components/translate/BUILD.gn
diff --git a/tools/gn/secondary/components/translate/BUILD.gn b/tools/gn/secondary/components/translate/BUILD.gn
index 2a076248594aef561bf933aeb5021e9b56fdebff..04cdfdd7761fefeffc2fd73d83687717129ebad7 100644
--- a/tools/gn/secondary/components/translate/BUILD.gn
+++ b/tools/gn/secondary/components/translate/BUILD.gn
@@ -2,18 +2,37 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-static_library("translate_common") {
+static_library("translate_core_common") {
external = true
sources = [
- "common/translate_constants.cc",
- "common/translate_constants.h",
- "common/translate_metrics.cc",
- "common/translate_metrics.h",
- "common/translate_switches.cc",
- "common/translate_switches.h",
- "common/translate_util.cc",
- "common/translate_util.h",
+ "core/common/translate_constants.cc",
+ "core/common/translate_constants.h",
+ "core/common/translate_errors.h",
+ "core/common/translate_metrics.cc",
+ "core/common/translate_metrics.h",
+ "core/common/translate_switches.cc",
+ "core/common/translate_switches.h",
+ "core/common/translate_util.cc",
+ "core/common/translate_util.h",
+ "core/common/language_detection_details.cc",
tfarina 2014/01/03 14:03:18 please, move this above translate_constants.cc
+ "core/common/language_detection_details.h",
+ ]
+
+ deps = [
+ "//base",
+ "//url",
+ ]
+}
+
+static_library("translate_core_browser") {
tfarina 2014/01/03 14:03:18 please, move core_browser before core_common?
+ external = true
+
+ sources = [
+ "core/browser/page_translated_details.h",
+ "core/browser/translate_error_details.h",
+ "core/browser/translate_event_details.cc",
+ "core/browser/translate_event_details.h",
]
deps = [
« no previous file with comments | « components/translate/language_detection/language_detection_util_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698