Move Translate-related files to components/translate

components/translate.gypi

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'targets': [
     {
-      'target_name': 'translate_common',
+      'target_name': 'translate_core_browser',
       'type': 'static_library',
       'dependencies': [
         '../base/base.gyp:base',

[blundell, 2014/01/06 12:04:52]

Should this depend on translate_core_common?

[droger, 2014/01/06 13:21:31]

Yes. Done.

         '../url/url.gyp:url_lib',
       ],
       'include_dirs': [
         '..',
       ],
       'sources': [
-        'translate/common/translate_constants.cc',
-        'translate/common/translate_constants.h',
-        'translate/common/translate_metrics.cc',
-        'translate/common/translate_metrics.h',
-        'translate/common/translate_switches.cc',
-        'translate/common/translate_switches.h',
-        'translate/common/translate_util.cc',
-        'translate/common/translate_util.h',
+        'translate/core/browser/page_translated_details.h',
+        'translate/core/browser/translate_error_details.h',

[blundell, 2014/01/06 12:04:52]

This file is duplicated below.

[droger, 2014/01/06 13:21:31]

No, it's slightly different ("event" instead of "error").

+        'translate/core/browser/translate_event_details.cc',
+        'translate/core/browser/translate_event_details.h',
+       ],
+    },
+    {
+      'target_name': 'translate_core_common',
+      'type': 'static_library',
+      'dependencies': [
+        '../base/base.gyp:base',
+        '../url/url.gyp:url_lib',
+      ],
+      'include_dirs': [
+        '..',
+      ],
+      'sources': [
+        'translate/core/common/translate_constants.cc',
+        'translate/core/common/translate_constants.h',
+        'translate/core/common/translate_errors.h',
+        'translate/core/common/translate_metrics.cc',
+        'translate/core/common/translate_metrics.h',
+        'translate/core/common/translate_switches.cc',
+        'translate/core/common/translate_switches.h',
+        'translate/core/common/translate_util.cc',
+        'translate/core/common/translate_util.h',
+        'translate/core/common/language_detection_details.cc',
+        'translate/core/common/language_detection_details.h',
       ],
     },
     {
       'target_name': 'translate_language_detection',
       'type': 'static_library',
       'dependencies': [
-        'translate_common',
+        'translate_core_common',
         '../base/base.gyp:base',
         '../url/url.gyp:url_lib',
       ],
       'include_dirs': [
         '..',
       ],
       'sources': [
         'translate/language_detection/language_detection_util.cc',
         'translate/language_detection/language_detection_util.h',
       ],
       'conditions': [
         ['cld_version==0 or cld_version==1', {
           'dependencies': [
             '<(DEPTH)/third_party/cld/cld.gyp:cld',
           ],
         }],
         ['cld_version==0 or cld_version==2', {
           'dependencies': [
             '<(DEPTH)/third_party/cld_2/cld_2.gyp:cld_2',
           ],
         }],
       ],
     },
   ],
 }