Move Translate-related files to components/translate

Move Translate-related files to components/translate

This CL moves a few files to the translate component. It also layers the
structure of the component so that it is better suited for iOS.

BUG=331509
TBR=jochen, joi

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243319

[droger, 2014-01-03 11:51:36]

I assume we need to wrap everything in the "translate" namespace?

[tfarina, 2014-01-03 11:54:00]

Can you see if this does not break the gn build?

$ gn
$ ninja -C out/Default translate_common

If yes, could you update tools/gn/secondary/components/translate/BUILD.gn?

Thanks!

[droger, 2014-01-03 12:46:48]

On 2014/01/03 11:54:00, tfarina wrote:
> Can you see if this does not break the gn build?
> 
> $ gn
> $ ninja -C out/Default translate_common
> 
> If yes, could you update tools/gn/secondary/components/translate/BUILD.gn?
> 
> Thanks!

I have a weird error I don't understand when I run your instructions (it's my
first time with gn):

rincewind:src droger$ ninja -C out/Default translate_core_common
ninja: Entering directory `out/Default'
[1/1] Regenerating ninja files
FAILED: ../Debug/gn --root=/Users/droger/dev/chromiumdesktop/src -q
/bin/sh: ../Debug/gn: No such file or directory
ninja: error: rebuilding 'build.ninja': subcommand failed

I did a speculative fix for the gn build though.

[droger, 2014-01-03 12:58:24]

On 2014/01/03 12:46:48, droger wrote:
> On 2014/01/03 11:54:00, tfarina wrote:
> > Can you see if this does not break the gn build?
> > 
> > $ gn
> > $ ninja -C out/Default translate_common
> > 
> > If yes, could you update tools/gn/secondary/components/translate/BUILD.gn?
> > 
> > Thanks!
> 
> I have a weird error I don't understand when I run your instructions (it's my
> first time with gn):
> 
> rincewind:src droger$ ninja -C out/Default translate_core_common
> ninja: Entering directory `out/Default'
> [1/1] Regenerating ninja files
> FAILED: ../Debug/gn --root=/Users/droger/dev/chromiumdesktop/src -q
> /bin/sh: ../Debug/gn: No such file or directory
> ninja: error: rebuilding 'build.ninja': subcommand failed
> 
> I did a speculative fix for the gn build though.

Ok, I figured it out.
The proper command for me line is:
ninja -C out/Debug translate_common

[tfarina, 2014-01-03 14:03:17]

GN changes lgtm, minor two requests below.

Thanks for fixing them!

https://codereview.chromium.org/93603006/diff/290001/tools/gn/secondary/compo...
File tools/gn/secondary/components/translate/BUILD.gn (right):

https://codereview.chromium.org/93603006/diff/290001/tools/gn/secondary/compo...
tools/gn/secondary/components/translate/BUILD.gn:18:
"core/common/language_detection_details.cc",
please, move this above translate_constants.cc

https://codereview.chromium.org/93603006/diff/290001/tools/gn/secondary/compo...
tools/gn/secondary/components/translate/BUILD.gn:28:
static_library("translate_core_browser") {
please, move core_browser before core_common?

[droger, 2014-01-03 14:28:46]

On 2014/01/03 14:03:17, tfarina wrote:
> GN changes lgtm, minor two requests below.
> 
> Thanks for fixing them!
> 
>
https://codereview.chromium.org/93603006/diff/290001/tools/gn/secondary/compo...
> File tools/gn/secondary/components/translate/BUILD.gn (right):
> 
>
https://codereview.chromium.org/93603006/diff/290001/tools/gn/secondary/compo...
> tools/gn/secondary/components/translate/BUILD.gn:18:
> "core/common/language_detection_details.cc",
> please, move this above translate_constants.cc
> 
>
https://codereview.chromium.org/93603006/diff/290001/tools/gn/secondary/compo...
> tools/gn/secondary/components/translate/BUILD.gn:28:
> static_library("translate_core_browser") {
> please, move core_browser before core_common?

Thanks!
Done.

[blundell, 2014-01-06 12:04:52]

LGTM with small questions. You should add a DEPS and README file to
//components/translate to reflect its being a layered component.

We will want to wrap everything in the translate namespace; as discussed
offline, it seems like a good plan to do that at the end of the componentization
work in order to avoid redundant work.

https://codereview.chromium.org/93603006/diff/370001/chrome/chrome_common.gypi
File chrome/chrome_common.gypi (right):

https://codereview.chromium.org/93603006/diff/370001/chrome/chrome_common.gyp...
chrome/chrome_common.gypi:42: '<(DEPTH)/content/content.gyp:content_common',
Should this depend on translate_core_common?

https://codereview.chromium.org/93603006/diff/370001/components/components_te...
File components/components_tests.gyp (right):

https://codereview.chromium.org/93603006/diff/370001/components/components_te...
components/components_tests.gyp:53:
'translate/language_detection/language_detection_util_unittest.cc',
This should move to translate/core/language_detection. Could you take note of
that somewhere?

https://codereview.chromium.org/93603006/diff/370001/components/translate.gypi
File components/translate.gypi (right):

https://codereview.chromium.org/93603006/diff/370001/components/translate.gyp...
components/translate.gypi:11: '../base/base.gyp:base',
Should this depend on translate_core_common?

https://codereview.chromium.org/93603006/diff/370001/components/translate.gyp...
components/translate.gypi:19:
'translate/core/browser/translate_error_details.h',
This file is duplicated below.

[blundell, 2014-01-06 12:08:02]

+mad for OWNERS.

[droger, 2014-01-06 13:21:30]

Thanks for the review.
I changed the README.

https://codereview.chromium.org/93603006/diff/370001/chrome/chrome_common.gypi
File chrome/chrome_common.gypi (right):

https://codereview.chromium.org/93603006/diff/370001/chrome/chrome_common.gyp...
chrome/chrome_common.gypi:42: '<(DEPTH)/content/content.gyp:content_common',
On 2014/01/06 12:04:52, blundell wrote:
> Should this depend on translate_core_common?

In chrome/common, only render_messages.h depends on it.
It's a .h file, but as discussed offline it's enough to require a dependency in
gyp.

That said, I expect the dependency to go away once translate IPC is moved from
render_messages.h to the component.

https://codereview.chromium.org/93603006/diff/370001/components/components_te...
File components/components_tests.gyp (right):

https://codereview.chromium.org/93603006/diff/370001/components/components_te...
components/components_tests.gyp:53:
'translate/language_detection/language_detection_util_unittest.cc',
On 2014/01/06 12:04:52, blundell wrote:
> This should move to translate/core/language_detection. Could you take note of
> that somewhere?

Filed http://crbug.com/331780

https://codereview.chromium.org/93603006/diff/370001/components/translate.gypi
File components/translate.gypi (right):

https://codereview.chromium.org/93603006/diff/370001/components/translate.gyp...
components/translate.gypi:11: '../base/base.gyp:base',
On 2014/01/06 12:04:52, blundell wrote:
> Should this depend on translate_core_common?

Yes. Done.

https://codereview.chromium.org/93603006/diff/370001/components/translate.gyp...
components/translate.gypi:19:
'translate/core/browser/translate_error_details.h',
On 2014/01/06 12:04:52, blundell wrote:
> This file is duplicated below.

No, it's slightly different ("event" instead of "error").

[MAD, 2014-01-07 15:49:40]

LGTM...

Thanks!

BYE
MAD

[commit-bot: I haz the power, 2014-01-07 16:01:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/droger@chromium.org/93603006/710001

[commit-bot: I haz the power, 2014-01-07 17:34:22]

Change committed as 243319