Issue 936003002: Make AstGraphBuilder::function_context a SetOncePointer again.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 936003002: Make AstGraphBuilder::function_context a SetOncePointer again. (Closed)

Created:
5 years, 10 months ago by Michael Starzinger

Modified:
5 years, 10 months ago

Reviewers:
titzer

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-graph-builder-stack-overflow

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Make AstGraphBuilder::function_context a SetOncePointer again. R=titzer@chromium.org

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -7 lines)			Patch
	M	src/compiler/ast-graph-builder.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
	M	src/compiler/ast-graph-builder.cc	View		4 chunks	+7 lines, -6 lines	0 comments	Download

Total messages: 3 (0 generated)

Michael Starzinger

Closing. Superseded by: https://codereview.chromium.org/934293002/

5 years, 10 months ago (2015-02-19 09:38:57 UTC) #2

titzer

5 years, 10 months ago (2015-02-19 09:39:22 UTC) #3

Message was sent while issue was closed.

On 2015/02/18 09:53:13, Michael Starzinger wrote:

My parallel CL which you reviewed does this already.