Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(813)

Issue 935983002: Remove obsolete code path that uses double as time stamp for metadata (Closed)

Created:
5 years, 10 months ago by Yang
Modified:
5 years, 10 months ago
Reviewers:
davidben
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove obsolete code path that uses double as time stamp for metadata in the HTTP cache. This is part 4/4 of a clean up to switch to int64 time stamps when caching metadata. The background to this is that converting int64 time stamps to double and back to int64 is lossy and causes false time stamp mismatches. BUG=453298 Committed: https://crrev.com/e88c0f1cd021ba15ab55dfdd363c8d8552514bd2 Cr-Commit-Position: refs/heads/master@{#317517}

Patch Set 1 #

Patch Set 2 : addressed comments #

Patch Set 3 : rebase #

Patch Set 4 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -18 lines) Patch
M content/child/web_url_loader_impl.cc View 1 2 3 1 chunk +1 line, -4 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 1 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Yang
Please take a look. This is part of a series of CLs between blink and ...
5 years, 10 months ago (2015-02-18 09:47:24 UTC) #2
davidben
(Going by review comments on parts 1 and 2, I expect this CL might end ...
5 years, 10 months ago (2015-02-18 18:52:15 UTC) #3
Yang
On 2015/02/18 18:52:15, David Benjamin wrote: > (Going by review comments on parts 1 and ...
5 years, 10 months ago (2015-02-19 08:41:22 UTC) #4
davidben
lgtm
5 years, 10 months ago (2015-02-19 21:40:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/935983002/80001
5 years, 10 months ago (2015-02-21 19:23:01 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:80001)
5 years, 10 months ago (2015-02-21 21:01:59 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-21 21:02:31 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/e88c0f1cd021ba15ab55dfdd363c8d8552514bd2
Cr-Commit-Position: refs/heads/master@{#317517}

Powered by Google App Engine
This is Rietveld 408576698