Issue 935973002: Clean up KeyframeEffectModelBase::updateNeutralKeyframeAnimatableValues()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 935973002: Clean up KeyframeEffectModelBase::updateNeutralKeyframeAnimatableValues() (Closed)

Created:
5 years, 10 months ago by alancutter (OOO until 2018)

Modified:
5 years, 10 months ago

Reviewers:
dstockwell

CC:
dstockwell, darktears, blink-reviews, blink-reviews-animation_chromium.org, Eric Willigers, Mike Lawther (Google), rjwright, shans, Steve Block, Timothy Loh

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Clean up KeyframeEffectModelBase::updateNeutralKeyframeAnimatableValues() This patch removes an unnecessary FIXME and makes an assert consistent with the rest of the code. The FIXME is unnecessary as we should never get neutral keyframes at offsets other than 0% and 100%. BUG=361948 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190814

Patch Set 1 #

Patch Set 2 : #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -7 lines)			Patch
	M	Source/core/animation/KeyframeEffectModel.cpp	View	1	1 chunk	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/935973002/20001

5 years, 10 months ago (2015-02-25 08:07:42 UTC) #6

commit-bot: I haz the power

5 years, 10 months ago (2015-02-25 09:24:33 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190814

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages