Make clicking the restart bubble for crashed apps work.

apps/app_load_service.cc

Index: apps/app_load_service.cc
diff --git a/apps/app_load_service.cc b/apps/app_load_service.cc
index 3526566f1568ecd07f52a2d04a42cc21a920a6df..a626b022336076a293eb172a6b3012ef992b1aed 100644
--- a/apps/app_load_service.cc
+++ b/apps/app_load_service.cc
@@ -43,11 +43,11 @@ AppLoadService::AppLoadService(Profile* profile)
 AppLoadService::~AppLoadService() {}
 
 void AppLoadService::RestartApplication(const std::string& extension_id) {
-  post_reload_actions_[extension_id].action_type = RESTART;
   ExtensionService* service = extensions::ExtensionSystem::Get(profile_)->
       extension_service();
   DCHECK(service);
   service->ReloadExtension(extension_id);
+  RestartPlatformApp(profile_, service->GetExtensionById(extension_id, false));

[tapted, 2013/12/12 06:54:52]

GetExtensionsById likes to return NULL a lot.. 

I think there's a pathological case for unpacked extensions, where the reload
needs some asynchronous file IO, so GetExtensionById returns NULL immediately
after ReloadExtension.

[koz (OOO until 15th September), 2013/12/13 03:33:56]

Ah, good spot! I've tried a different approach in the latest patchset - wait for
the NOTIFICATION_EXTENSION_LOADED instead of NOTIFICATION_HOST_DID_STOP_LOADING
because the former always fires for reloads. Doing so means we need to check for
registered events rather than actual listeners. Registered events are events
that an app app should have listeners for, even if the app isn't running, and we
need to check them because they are only converted into real listeners at
NOTIFICATION_EXTENSION_LOADED time, which means we can't assume that the
listeners will be populated in our own LOADED listener.

WDYT?

 }
 
 bool AppLoadService::LoadAndLaunch(const base::FilePath& extension_path,
@@ -94,9 +94,6 @@ void AppLoadService::Observe(int type,
         case LAUNCH:
           LaunchPlatformApp(profile_, extension);
           break;
-        case RESTART:
-          RestartPlatformApp(profile_, extension);
-          break;
         case LAUNCH_WITH_COMMAND_LINE:
           LaunchPlatformAppWithCommandLine(
               profile_, extension, &it->second.command_line,