Make clicking the restart bubble for crashed apps work.

apps/launcher.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "apps/launcher.h"
 
 #include "apps/apps_client.h"
 #include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/files/file_path.h"
@@ skipping 360 matching lines @@
 void RestartPlatformApp(Profile* profile, const Extension* extension) {
 #if defined(OS_WIN)
   // On Windows 8's single window Metro mode we can not launch platform apps.
   // In restart we are just making sure launch doesn't slip through.
   if (win8::IsSingleWindowMetroMode())
     return;
 #endif
   extensions::EventRouter* event_router =
       ExtensionSystem::Get(profile)->event_router();
   bool listening_to_restart = event_router->
       ExtensionHasEventListener(extension->id(),

[tapted, 2013/12/13 04:34:24]

Should this be updated as well, to be consistent? Although, maybe it's a good
sideffect now that [i think] an extension that has its extension bubble clicked
that has BOTH OnRestarted and OnLaunched will now get an OnLaunched (rather than
OnRestarted only).

But, it's subtle - maybe a comment?

[koz (OOO until 15th September), 2013/12/16 01:49:00]

Ooh, actually this should be consistent. The effect of it not being consistent
is that this code won't execute at all from the crash bubble, ie: it will only
get onLaunched and not onRestarted, even if it's listening for onRestarted.

                                 app_runtime::OnRestarted::kEventName);
 
   if (listening_to_restart) {
     extensions::AppEventRouter::DispatchOnRestartedEvent(profile, extension);
     return;
   }
 
   extensions::ExtensionPrefs* extension_prefs = ExtensionSystem::Get(profile)->
       extension_service()->extension_prefs();
   bool had_windows = extension_prefs->IsActive(extension->id());
   extension_prefs->SetIsActive(extension->id(), false);
-  bool listening_to_launch = event_router->
-      ExtensionHasEventListener(extension->id(),
-                                app_runtime::OnLaunched::kEventName);
+  std::set<std::string> events =

[tapted, 2013/12/13 04:34:24]

nit: you could avoid the local `events` variable with something like:

bool listening_to_launch = event_router->GetRegisteredEvents(extension->id())
    .count(app_runtime::OnLaunched::kEventName) != 0;

Also maybe a comment like `Read from the events registered in prefs, since
listeners have not yet been created.`. Assuming that's true :) [that's my
reading of the diff anyway].

[koz (OOO until 15th September), 2013/12/16 01:49:00]

Sam has informed me of ContainsKey() which seems like the best of both worlds. I
added the comment above.

+      event_router->GetRegisteredEvents(extension->id());
+  bool listening_to_launch =
+      events.find(app_runtime::OnLaunched::kEventName) != events.end();
 
   if (listening_to_launch && had_windows)
     LaunchPlatformAppWithNoData(profile, extension);
 }
 
 void LaunchPlatformAppWithUrl(Profile* profile,
                               const Extension* extension,
                               const std::string& handler_id,
                               const GURL& url,
                               const GURL& referrer_url) {
   extensions::AppEventRouter::DispatchOnLaunchedEventWithUrl(
       profile, extension, handler_id, url, referrer_url);
 }
 
 }  // namespace apps