Calc USB scancodes for key events (linux only for now)

Calc USB scancodes for key events (linux only for now)

This is basically reviving cl/6691066.

BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=123852

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124009

[Jamie, 2012-02-15 00:44:41]

lgtm

[Sergey Ulanov, 2012-02-15 01:08:12]

couple of drive-by style nits

http://codereview.chromium.org/9359048/diff/2001/webkit/plugins/ppapi/usb_sca...
File webkit/plugins/ppapi/usb_scan_code_conversion.h (right):

http://codereview.chromium.org/9359048/diff/2001/webkit/plugins/ppapi/usb_sca...
webkit/plugins/ppapi/usb_scan_code_conversion.h:1: // Copyright (c) 2011 The
Chromium Authors. All rights reserved.
2012

http://codereview.chromium.org/9359048/diff/2001/webkit/plugins/ppapi/usb_sca...
webkit/plugins/ppapi/usb_scan_code_conversion.h:12: }
  // namespace WebKit

[garykac, 2012-02-16 21:12:56]

http://codereview.chromium.org/9359048/diff/2001/webkit/plugins/ppapi/usb_sca...
File webkit/plugins/ppapi/usb_scan_code_conversion.h (right):

http://codereview.chromium.org/9359048/diff/2001/webkit/plugins/ppapi/usb_sca...
webkit/plugins/ppapi/usb_scan_code_conversion.h:1: // Copyright (c) 2011 The
Chromium Authors. All rights reserved.
On 2012/02/15 01:08:12, sergeyu wrote:
> 2012

Done.

http://codereview.chromium.org/9359048/diff/2001/webkit/plugins/ppapi/usb_sca...
webkit/plugins/ppapi/usb_scan_code_conversion.h:12: }
On 2012/02/15 01:08:12, sergeyu wrote:
>   // namespace WebKit

Done.

[Wez, 2012-02-17 01:35:29]

LGTM, assuming that the mapping table is correct! :)

http://codereview.chromium.org/9359048/diff/4001/webkit/plugins/ppapi/usb_sca...
File webkit/plugins/ppapi/usb_scan_code_conversion.cc (right):

http://codereview.chromium.org/9359048/diff/4001/webkit/plugins/ppapi/usb_sca...
webkit/plugins/ppapi/usb_scan_code_conversion.cc:7: #include
"third_party/WebKit/Source/WebKit/chromium/public/WebInputEvent.h"
nit: No need to include this since we don't use it?

http://codereview.chromium.org/9359048/diff/4001/webkit/plugins/ppapi/usb_sca...
File webkit/plugins/ppapi/usb_scan_code_conversion.h (right):

http://codereview.chromium.org/9359048/diff/4001/webkit/plugins/ppapi/usb_sca...
webkit/plugins/ppapi/usb_scan_code_conversion.h:22: uint32_t
UsbScanCodeForKeyboardEvent(const WebKit::WebKeyboardEvent& key_event);
See previous CL re USB "scan code" vs "key code".

[garykac, 2012-02-22 21:31:07]

http://codereview.chromium.org/9359048/diff/4001/webkit/plugins/ppapi/usb_sca...
File webkit/plugins/ppapi/usb_scan_code_conversion.cc (right):

http://codereview.chromium.org/9359048/diff/4001/webkit/plugins/ppapi/usb_sca...
webkit/plugins/ppapi/usb_scan_code_conversion.cc:7: #include
"third_party/WebKit/Source/WebKit/chromium/public/WebInputEvent.h"
On 2012/02/17 01:35:30, Wez wrote:
> nit: No need to include this since we don't use it?

Done.

http://codereview.chromium.org/9359048/diff/4001/webkit/plugins/ppapi/usb_sca...
File webkit/plugins/ppapi/usb_scan_code_conversion.h (right):

http://codereview.chromium.org/9359048/diff/4001/webkit/plugins/ppapi/usb_sca...
webkit/plugins/ppapi/usb_scan_code_conversion.h:22: uint32_t
UsbScanCodeForKeyboardEvent(const WebKit::WebKeyboardEvent& key_event);
On 2012/02/17 01:35:30, Wez wrote:
> See previous CL re USB "scan code" vs "key code".

Done.

[commit-bot: I haz the power, 2012-02-22 21:38:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/garykac@chromium.org/9359048/8001

[commit-bot: I haz the power, 2012-02-22 21:38:18]

Presubmit check for 9359048-8001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
webkit/plugins/ppapi/usb_key_code_conversion_linux.cc,webkit/glue/webkit_glue.gypi,webkit/plugins/ppapi/event_conversion.cc,webkit/plugins/ppapi/usb_key_code_conversion.h,webkit/plugins/ppapi/usb_key_code_conversion.cc

Presubmit checks took 1.2s to calculate.

[garykac, 2012-02-22 23:03:57]

+darin for webkit

[garykac, 2012-02-23 00:22:14]

+dmichael for the webkit/plugin/ppapi stuff
(darin still needed for the gypi change)

[dmichael (off chromium), 2012-02-23 17:05:42]

Aren't you going to get duplicate definition errors on non-Linux platforms? You
might need to add a rule to exclude *_linux.cc for non-linux platforms to the
gypi file.

o/w LGTM

[garykac, 2012-02-24 02:33:08]

On 2012/02/23 17:05:42, dmichael wrote:
> Aren't you going to get duplicate definition errors on non-Linux platforms?
You
> might need to add a rule to exclude *_linux.cc for non-linux platforms to the
> gypi file.

Files that end in _linux (and _win, _mac) are automagically filtered out for
platforms where they don't apply.

[garykac, 2012-02-24 20:26:23]

ping - still needs lgtm from an owner of webkit/glue

[tony, 2012-02-27 22:10:41]

webkit/glue LGTM

[garykac, 2012-02-27 22:22:11]

On 2012/02/27 22:10:41, tony wrote:
> webkit/glue LGTM

Thanks!

[commit-bot: I haz the power, 2012-02-27 23:26:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/garykac@chromium.org/9359048/8001

[commit-bot: I haz the power, 2012-02-28 01:36:48]

Change committed as 123852