Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 935893002: Don't show launcher or chrome://apps after adding a bookmark app. (Closed)

Created:
5 years, 10 months ago by benwells
Modified:
5 years, 10 months ago
Reviewers:
jackhou1
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't show launcher or chrome://apps after adding a bookmark app. BUG=459082 Committed: https://crrev.com/b3ac630ab573300d63d7d3f7f818cf89f44f7837 Cr-Commit-Position: refs/heads/master@{#316775}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Put back callback call. #

Patch Set 3 : Fix compile on mac; incognito on mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -21 lines) Patch
M chrome/browser/extensions/bookmark_app_helper.cc View 1 2 2 chunks +5 lines, -21 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
benwells
This came out of UI review.
5 years, 10 months ago (2015-02-18 02:46:50 UTC) #2
jackhou1
https://codereview.chromium.org/935893002/diff/1/chrome/browser/extensions/bookmark_app_helper.cc File chrome/browser/extensions/bookmark_app_helper.cc (left): https://codereview.chromium.org/935893002/diff/1/chrome/browser/extensions/bookmark_app_helper.cc#oldcode472 chrome/browser/extensions/bookmark_app_helper.cc:472: callback_.Run(extension, web_app_info_); I think you still need to call ...
5 years, 10 months ago (2015-02-18 02:56:10 UTC) #3
benwells
https://codereview.chromium.org/935893002/diff/1/chrome/browser/extensions/bookmark_app_helper.cc File chrome/browser/extensions/bookmark_app_helper.cc (left): https://codereview.chromium.org/935893002/diff/1/chrome/browser/extensions/bookmark_app_helper.cc#oldcode472 chrome/browser/extensions/bookmark_app_helper.cc:472: callback_.Run(extension, web_app_info_); On 2015/02/18 02:56:10, jackhou1 wrote: > I ...
5 years, 10 months ago (2015-02-18 03:10:45 UTC) #4
jackhou1
lgtm
5 years, 10 months ago (2015-02-18 03:14:48 UTC) #5
jackhou1
Patch Set 3 lgtm, works for normal and incognito.
5 years, 10 months ago (2015-02-18 04:09:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/935893002/40001
5 years, 10 months ago (2015-02-18 04:23:25 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-18 05:53:33 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-18 05:54:21 UTC) #11
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/b3ac630ab573300d63d7d3f7f818cf89f44f7837
Cr-Commit-Position: refs/heads/master@{#316775}

Powered by Google App Engine
This is Rietveld 408576698