Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 935843003: Make gcmole correctly handle 32 bit architectures. (Closed)

Created:
5 years, 10 months ago by Michael Achenbach
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make gcmole correctly handle 32 bit architectures. NOTRY=true Committed: https://crrev.com/7307bf0ff3b236308e5eee20b7a8bab26395d229 Cr-Commit-Position: refs/heads/master@{#26723}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -6 lines) Patch
M tools/gcmole/gcmole.lua View 1 3 chunks +13 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Michael Achenbach
PTAL
5 years, 10 months ago (2015-02-18 09:25:49 UTC) #2
Michael Starzinger
LGTM, if it works with the Clang built by tools/gcmole/bootstrap.sh as well. https://codereview.chromium.org/935843003/diff/1/tools/gcmole/gcmole.lua File tools/gcmole/gcmole.lua ...
5 years, 10 months ago (2015-02-18 09:41:55 UTC) #3
Michael Achenbach
Done. Well, the boostrapper doesn't work on my workstation. Maybe it broke after the trusty ...
5 years, 10 months ago (2015-02-18 11:15:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/935843003/20001
5 years, 10 months ago (2015-02-18 14:50:55 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-18 14:51:03 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-18 14:51:27 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7307bf0ff3b236308e5eee20b7a8bab26395d229
Cr-Commit-Position: refs/heads/master@{#26723}

Powered by Google App Engine
This is Rietveld 408576698