Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 93583003: Reland 237634 and 237645. (Closed)

Created:
7 years ago by hshi1
Modified:
7 years ago
Reviewers:
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org, miu+watch_chromium.org
Visibility:
Public.

Description

Reland 237634 and 237645. (1) Implement DesktopCaptureDeviceAsh based on CopyOutputRequest. The new implementation captures the Ash desktop by issuing CopyOutputRequest on the layer associated with the root window of the desktop. Desktop capture using this path is only feasible on Ash at this moment, where the aura root window corresponds to the entire desktop. On other platforms the aura root window is mapped to a native window. Refactor WebContentsVideoCaptureDevice::Impl and share the class ThreadSafeCaptureOracle between web contents capture and desktop capture. The existing X11 desktop capture path is inefficient especially on ARM devices. This CL leverages hardware-accelerated copy and encoding to achieve performance on par with tab capture. Measured desktop capture frame rate on daisy: Before this CL: 6~7 fps After this CL: 18~23 fps depending on content (2) Fix memory leak in DesktopCaptureDeviceAshTest on Linux Chromium OS ASAN. (3) Disable failing DesktopCaptureApiTest.ChooseDesktopMedia on ChromeOS. See http://crbug.com/324179 BUG=310372 TEST=trybots, verify tab/screen capture locally on devices R=creis@chromium.org, sergeyu@chromium.org TBR=ernstm@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237732

Patch Set 1 #

Patch Set 2 : Disabled failing test. #

Patch Set 3 : Rebase at 237726. #

Messages

Total messages: 1 (0 generated)
hshi1
7 years ago (2013-11-28 07:20:53 UTC) #1
Message was sent while issue was closed.
Committed patchset #3 manually as r237732 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698