DescriptionRevert 237558 "Use MIDIMessageQueue/IsValidWebMIDIData for MIDI ..."
Seems to have caused issues running perf tests.
BUG=324160
> Use MIDIMessageQueue/IsValidWebMIDIData for MIDI byte stream validation
>
> WebMIDI spec draft: http://www.w3.org/TR/webmidi/
>
> WebMIDI API guarantees that MIDIInput::onmessage is called back with a single MIDI message. To guarantee this, this CL introduces MIDIMessageQueue class, which allows you to
> - maintain fragmented MIDI message.
> - Skip any invalid data sequence.
> - Reorder MIDI messages so that "System Real Time Message", which can be inserted at any point of the byte stream, can be placed at the boundary of complete MIDI messages.
> - (Optional) Reconstruct complete MIDI messages from data stream that is compressed with "running status".
>
> This CL also replaces existing System Exclusive message validation logic in MIDIHost::OnSendData with MIDIHost::IsValidWebMIDIData, which can detect SysEx message even when it is concatenated with non-SysEx messages.
>
> With this change, renderer/blink can be much simpler and free from this kind of data validation.
>
> BUG=303599, 317355
> TEST=media_unittests --gtest_filter=MIDI*, content_unittests --gtest_filter=MIDI*
>
> Review URL: https://codereview.chromium.org/68353002
TBR=yukawa@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237660
Patch Set 1 #Messages
Total messages: 4 (0 generated)
|