Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 935773003: Android Chromoting: Update Play Store What's-New text (Closed)

Created:
5 years, 10 months ago by Lambros
Modified:
5 years, 10 months ago
Reviewers:
hbengali, Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Android Chromoting: Update Play Store What's-New text Committed: https://crrev.com/72b4f2deb9eaf9c0048ef92a0f4c18011b4b6c24 Cr-Commit-Position: refs/heads/master@{#316756}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M remoting/resources/remoting_strings.grd View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Lambros
Not sure how best to phrase this so it gets translated properly. Also, I wondered ...
5 years, 10 months ago (2015-02-17 23:16:28 UTC) #2
Jamie
lgtm https://codereview.chromium.org/935773003/diff/1/remoting/resources/remoting_strings.grd File remoting/resources/remoting_strings.grd (right): https://codereview.chromium.org/935773003/diff/1/remoting/resources/remoting_strings.grd#newcode617 remoting/resources/remoting_strings.grd:617: • New Material Design interface. How about just ...
5 years, 10 months ago (2015-02-17 23:43:09 UTC) #3
Lambros
ptal
5 years, 10 months ago (2015-02-18 00:51:44 UTC) #5
Jamie
lgtm
5 years, 10 months ago (2015-02-18 01:00:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/935773003/20001
5 years, 10 months ago (2015-02-18 01:58:56 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-18 03:11:31 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-18 03:12:02 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/72b4f2deb9eaf9c0048ef92a0f4c18011b4b6c24
Cr-Commit-Position: refs/heads/master@{#316756}

Powered by Google App Engine
This is Rietveld 408576698