Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 935753003: Added llvm into exceptions as we can't add README.chromium into 3rd party repository (Closed)

Created:
5 years, 10 months ago by Sergiy Byelozyorov
Modified:
5 years, 10 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added llvm into exceptions as we can't add README.chromium into 3rd party repository BUG=451020 R=mnaganov@chromium.org,phajdan.jr@chromium.org Committed: https://crrev.com/0a7adf8fde0ab0710987dd2a69293e5065c6b9a9 Cr-Commit-Position: refs/heads/master@{#317168}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M android_webview/tools/known_issues.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Sergiy Byelozyorov
5 years, 10 months ago (2015-02-18 00:08:04 UTC) #1
Sergiy Byelozyorov
ping
5 years, 10 months ago (2015-02-19 00:47:45 UTC) #2
Torne
mnaganov is on vacation; I can help you with this. Where is the original change ...
5 years, 10 months ago (2015-02-19 10:31:47 UTC) #4
Torne
The right thing to do is probably to add an entry to SPECIAL_CASES in src/tools/licenses.py, ...
5 years, 10 months ago (2015-02-19 10:40:14 UTC) #5
mnaganov (inactive)
On 2015/02/19 10:40:14, Torne wrote: > The right thing to do is probably to add ...
5 years, 10 months ago (2015-02-19 20:50:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/935753003/1
5 years, 10 months ago (2015-02-19 23:14:09 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-19 23:36:31 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 23:37:35 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0a7adf8fde0ab0710987dd2a69293e5065c6b9a9
Cr-Commit-Position: refs/heads/master@{#317168}

Powered by Google App Engine
This is Rietveld 408576698