Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 935743004: Remove irt_nonsfi.h, which is no longer necessary. (Closed)

Created:
5 years, 10 months ago by mazda
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove irt_nonsfi.h, which is no longer necessary. The definition of nacl_irt_icache was moved to irt.h in the NaCl repository, so irt_nonsfi.h is no longer necessary. BUG= https://code.google.com/p/nativeclient/issues/detail?id=4033 Committed: https://crrev.com/0b3f8339485a7dd513757d3119853835e6e9b1da Cr-Commit-Position: refs/heads/master@{#317728}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -32 lines) Patch
M components/nacl/loader/nonsfi/irt_interfaces.h View 1 chunk +0 lines, -1 line 0 comments Download
D ppapi/nacl_irt/public/irt_nonsfi.h View 1 chunk +0 lines, -31 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
mazda
PTAL
5 years, 10 months ago (2015-02-23 04:29:57 UTC) #2
Mark Seaborn
Fix typo ("wsa"), then LGTM, thanks.
5 years, 10 months ago (2015-02-23 06:48:36 UTC) #3
mazda
> Fix typo ("wsa") Done, thanks. dmichael@ Could you do an OWNERS review for ppapi/? ...
5 years, 10 months ago (2015-02-23 10:54:31 UTC) #4
dmichael (off chromium)
lgtm
5 years, 10 months ago (2015-02-23 16:22:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/935743004/20001
5 years, 10 months ago (2015-02-24 01:20:10 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-24 01:36:48 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 01:37:35 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0b3f8339485a7dd513757d3119853835e6e9b1da
Cr-Commit-Position: refs/heads/master@{#317728}

Powered by Google App Engine
This is Rietveld 408576698