bpf_dsl: move Verifier into PolicyCompiler

bpf_dsl: move Verifier into PolicyCompiler

This makes it easier to run verification within bpf_dsl_unittests too,
though it also exposes that FakeTrapRegistry was being sloppy by not
reusing trap IDs when a trap handler is assigned a second time.

BUG=449357
Committed: https://crrev.com/5953fcd58676131a348132b8058981c1ccf084c8
Cr-Commit-Position: refs/heads/master@{#319683}

[mdempsky, 2015-02-20 07:37:38]

mdempsky@chromium.org changed reviewers:
+ jln@chromium.org

[jln (very slow on Chromium), 2015-02-21 01:48:48]

lgtm

https://chromiumcodereview.appspot.com/935743003/diff/1/sandbox/linux/bpf_dsl...
File sandbox/linux/bpf_dsl/bpf_dsl_unittest.cc (right):

https://chromiumcodereview.appspot.com/935743003/diff/1/sandbox/linux/bpf_dsl...
sandbox/linux/bpf_dsl/bpf_dsl_unittest.cc:100: FakeTrapRegistry traps;
Maybe add a comment: run twice to check that Trap IDs are being re-used?

https://chromiumcodereview.appspot.com/935743003/diff/1/sandbox/linux/bpf_dsl...
File sandbox/linux/bpf_dsl/verifier.cc (right):

https://chromiumcodereview.appspot.com/935743003/diff/1/sandbox/linux/bpf_dsl...
sandbox/linux/bpf_dsl/verifier.cc:75: uint32_t policy_ret =
EvaluateErrorCode(compiler, root_code, *data);
const?

[mdempsky, 2015-02-23 03:53:20]

New patchsets have been uploaded after l-g-t-m from jln@chromium.org

[mdempsky, 2015-02-23 03:54:24]

https://codereview.chromium.org/935743003/diff/1/sandbox/linux/bpf_dsl/bpf_ds...
File sandbox/linux/bpf_dsl/bpf_dsl_unittest.cc (right):

https://codereview.chromium.org/935743003/diff/1/sandbox/linux/bpf_dsl/bpf_ds...
sandbox/linux/bpf_dsl/bpf_dsl_unittest.cc:100: FakeTrapRegistry traps;
On 2015/02/21 01:48:48, jln wrote:
> Maybe add a comment: run twice to check that Trap IDs are being re-used?

Done.

https://codereview.chromium.org/935743003/diff/1/sandbox/linux/bpf_dsl/verifi...
File sandbox/linux/bpf_dsl/verifier.cc (right):

https://codereview.chromium.org/935743003/diff/1/sandbox/linux/bpf_dsl/verifi...
sandbox/linux/bpf_dsl/verifier.cc:75: uint32_t policy_ret =
EvaluateErrorCode(compiler, root_code, *data);
On 2015/02/21 01:48:48, jln wrote:
> const?

Done.

[mdempsky, 2015-02-23 03:54:30]

The CQ bit was checked by mdempsky@chromium.org

[commit-bot: I haz the power, 2015-02-23 03:55:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/935743003/20001

[commit-bot: I haz the power, 2015-02-23 03:58:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-23 03:58:03]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[mdempsky, 2015-02-23 03:58:29]

The CQ bit was unchecked by mdempsky@chromium.org

[mdempsky, 2015-03-09 16:36:25]

The CQ bit was checked by mdempsky@chromium.org

[commit-bot: I haz the power, 2015-03-09 16:36:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/935743003/20001

[commit-bot: I haz the power, 2015-03-09 18:06:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-09 18:06:57]

Patchset 2 (id:??) landed as
https://crrev.com/5953fcd58676131a348132b8058981c1ccf084c8
Cr-Commit-Position: refs/heads/master@{#319683}