Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: src/full-codegen.cc

Issue 935723004: Rename Interface to ModuleDescriptor (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/flag-definitions.h ('k') | src/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/full-codegen.cc
diff --git a/src/full-codegen.cc b/src/full-codegen.cc
index 8cc7f8205941b16a4294d704f4e1f1d62a06a79e..6f43497a799ed73d0d6b1c6845d6bfcb400fb36f 100644
--- a/src/full-codegen.cc
+++ b/src/full-codegen.cc
@@ -610,14 +610,13 @@ void FullCodeGenerator::AllocateModules(ZoneList<Declaration*>* declarations) {
if (module != NULL) {
Comment cmnt(masm_, "[ Link nested modules");
Scope* scope = module->body()->scope();
- Interface* interface = scope->interface();
- DCHECK(interface->IsFrozen());
+ DCHECK(scope->module()->IsFrozen());
- interface->Allocate(scope->module_var()->index());
+ scope->module()->Allocate(scope->module_var()->index());
// Set up module context.
- DCHECK(scope->interface()->Index() >= 0);
- __ Push(Smi::FromInt(scope->interface()->Index()));
+ DCHECK(scope->module()->Index() >= 0);
+ __ Push(Smi::FromInt(scope->module()->Index()));
__ Push(scope->GetScopeInfo(isolate()));
__ CallRuntime(Runtime::kPushModuleContext, 2);
StoreToFrameField(StandardFrameConstants::kContextOffset,
@@ -751,7 +750,7 @@ void FullCodeGenerator::VisitModuleLiteral(ModuleLiteral* module) {
Block* block = module->body();
Scope* saved_scope = scope();
scope_ = block->scope();
- Interface* interface = scope_->interface();
+ ModuleDescriptor* descriptor = scope_->module();
Comment cmnt(masm_, "[ ModuleLiteral");
SetStatementPosition(block);
@@ -761,8 +760,8 @@ void FullCodeGenerator::VisitModuleLiteral(ModuleLiteral* module) {
int index = module_index_++;
// Set up module context.
- DCHECK(interface->Index() >= 0);
- __ Push(Smi::FromInt(interface->Index()));
+ DCHECK(descriptor->Index() >= 0);
+ __ Push(Smi::FromInt(descriptor->Index()));
__ Push(Smi::FromInt(0));
__ CallRuntime(Runtime::kPushModuleContext, 2);
StoreToFrameField(StandardFrameConstants::kContextOffset, context_register());
@@ -774,7 +773,7 @@ void FullCodeGenerator::VisitModuleLiteral(ModuleLiteral* module) {
// Populate the module description.
Handle<ModuleInfo> description =
- ModuleInfo::Create(isolate(), interface, scope_);
+ ModuleInfo::Create(isolate(), descriptor, scope_);
modules_->set(index, *description);
scope_ = saved_scope;
@@ -785,26 +784,13 @@ void FullCodeGenerator::VisitModuleLiteral(ModuleLiteral* module) {
}
+// TODO(adamk): Delete ModulePath.
void FullCodeGenerator::VisitModulePath(ModulePath* module) {
- // Nothing to do.
- // The instance object is resolved statically through the module's interface.
}
+// TODO(adamk): Delete ModuleUrl.
void FullCodeGenerator::VisitModuleUrl(ModuleUrl* module) {
- // TODO(rossberg): dummy allocation for now.
- Scope* scope = module->body()->scope();
- Interface* interface = scope_->interface();
-
- DCHECK(interface->IsFrozen());
- DCHECK(!modules_.is_null());
- DCHECK(module_index_ < modules_->length());
- interface->Allocate(scope->module_var()->index());
- int index = module_index_++;
-
- Handle<ModuleInfo> description =
- ModuleInfo::Create(isolate(), interface, scope_);
- modules_->set(index, *description);
}
@@ -1095,7 +1081,7 @@ void FullCodeGenerator::VisitModuleStatement(ModuleStatement* stmt) {
DCHECK(stmt->body()->scope()->is_module_scope());
- __ Push(Smi::FromInt(stmt->body()->scope()->interface()->Index()));
+ __ Push(Smi::FromInt(stmt->body()->scope()->module()->Index()));
__ Push(Smi::FromInt(0));
__ CallRuntime(Runtime::kPushModuleContext, 2);
StoreToFrameField(
« no previous file with comments | « src/flag-definitions.h ('k') | src/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698