Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 935723004: Rename Interface to ModuleDescriptor (Closed)

Created:
5 years, 10 months ago by adamk
Modified:
5 years, 10 months ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Rename Interface to ModuleDescriptor ModuleDescriptor will end up holding the set of data described in the spec as a "Module record". This introduces a little bit of confusion with ModuleInfo, but I hope that'll become clearer over time. Also removed the interface-printing flags. We probably want Module-printing flags, but that can wait until we have more Module-related structures. BUG=v8:1569 LOG=n Committed: https://crrev.com/27e8a455df96311db6fb3b50fb3b371e72a61eca Cr-Commit-Position: refs/heads/master@{#26728}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -343 lines) Patch
M BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/ast.h View 4 chunks +11 lines, -14 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/full-codegen.cc View 6 chunks +11 lines, -25 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +3 lines, -3 lines 0 comments Download
D src/interface.h View 1 chunk +0 lines, -111 lines 0 comments Download
D src/interface.cc View 1 chunk +0 lines, -101 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + src/modules.h View 5 chunks +12 lines, -24 lines 0 comments Download
A src/modules.cc View 1 chunk +38 lines, -0 lines 0 comments Download
M src/parser.cc View 4 chunks +8 lines, -12 lines 0 comments Download
M src/ppc/full-codegen-ppc.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/scopeinfo.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/scopeinfo.cc View 1 chunk +7 lines, -6 lines 0 comments Download
M src/scopes.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/scopes.cc View 5 chunks +5 lines, -10 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/x87/full-codegen-x87.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/gyp/v8.gyp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
adamk
5 years, 10 months ago (2015-02-17 23:19:38 UTC) #2
rossberg
lgtm
5 years, 10 months ago (2015-02-18 07:39:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/935723004/1
5 years, 10 months ago (2015-02-18 18:19:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-18 18:25:08 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-18 18:25:30 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/27e8a455df96311db6fb3b50fb3b371e72a61eca
Cr-Commit-Position: refs/heads/master@{#26728}

Powered by Google App Engine
This is Rietveld 408576698