Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 935723002: Promote "netlog" tracing category to a default category (Closed)

Created:
5 years, 10 months ago by xunjieli
Modified:
5 years, 10 months ago
Reviewers:
nduca, mmenke
CC:
cbentzel+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Promote "netlog" tracing category to a default category This CL removes the "disabled-by-default-" prefix when logging "netlog" events in tracing. This CL is a part of the effort to deprecate the old "net" events, and promote the new "netlog" events. BUG=456114 Committed: https://crrev.com/654aa66333b3a295a480542c1523ca273cfa1ad8 Cr-Commit-Position: refs/heads/master@{#318241}

Patch Set 1 #

Patch Set 2 : Test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M net/base/trace_net_log_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/trace_net_log_observer_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
nduca
lgtm
5 years, 10 months ago (2015-02-25 21:48:31 UTC) #2
xunjieli
Matt, Nat thinks it'd be best if we promote "netlog" category to a default category ...
5 years, 10 months ago (2015-02-25 21:53:34 UTC) #4
mmenke
On 2015/02/25 21:53:34, xunjieli wrote: > Matt, Nat thinks it'd be best if we promote ...
5 years, 10 months ago (2015-02-25 23:48:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/935723002/1
5 years, 10 months ago (2015-02-26 13:52:29 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/172)
5 years, 10 months ago (2015-02-26 14:11:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/935723002/20001
5 years, 10 months ago (2015-02-26 15:03:10 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-26 16:14:43 UTC) #13
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 16:15:19 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/654aa66333b3a295a480542c1523ca273cfa1ad8
Cr-Commit-Position: refs/heads/master@{#318241}

Powered by Google App Engine
This is Rietveld 408576698