Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Issue 935673004: Extract creation of PWG Raster converter settings out of privet_http_impl (Closed)

Created:
5 years, 10 months ago by tbarzic
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Extract creation of PWG Raster converter settings out of privet_http_impl Moves creation of conversion_settings and bitmap_settings needed by PWGRasterConverter::Start to a place usable by code for handling extension printers. This will enable extension printer handler to reuse the code when converting pdf documents to PWG raster data. BUG=408772 TEST=existing tests Committed: https://crrev.com/885330e8a260d0f76a8f41536a0c011b21839d70 Cr-Commit-Position: refs/heads/master@{#316958}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -74 lines) Patch
M chrome/browser/local_discovery/privet_http_impl.h View 1 2 3 3 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/local_discovery/privet_http_impl.cc View 1 2 3 5 chunks +3 lines, -68 lines 0 comments Download
M chrome/browser/local_discovery/pwg_raster_converter.h View 2 chunks +17 lines, -0 lines 0 comments Download
M chrome/browser/local_discovery/pwg_raster_converter.cc View 3 chunks +73 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tbarzic
Let me know if you know a better place to put these..
5 years, 10 months ago (2015-02-18 02:55:44 UTC) #2
Vitaly Buka (NO REVIEWS)
lgtm
5 years, 10 months ago (2015-02-18 23:43:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/935673004/60001
5 years, 10 months ago (2015-02-18 23:51:06 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-19 01:34:56 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 01:35:44 UTC) #7
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/885330e8a260d0f76a8f41536a0c011b21839d70
Cr-Commit-Position: refs/heads/master@{#316958}

Powered by Google App Engine
This is Rietveld 408576698