Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: chrome/browser/net/certificate_error_reporter.h

Issue 935663004: Add checkbox for reporting invalid TLS/SSL cert chains (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: send cookies on SB requests, and use .Pass instead of .release Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/certificate_error_reporter.h
diff --git a/chrome/browser/net/certificate_error_reporter.h b/chrome/browser/net/certificate_error_reporter.h
index 5463d5a74bd69d6286bbb8cbe1115fc78e8bcd41..14d759b0c3439ef62624475b55aeff40e6e42ee9 100644
--- a/chrome/browser/net/certificate_error_reporter.h
+++ b/chrome/browser/net/certificate_error_reporter.h
@@ -22,6 +22,8 @@ namespace chrome_browser_net {
class CertLoggerRequest;
+extern const char kExtendedReportingUploadUrl[];
+
// Provides functionality for sending reports about invalid SSL
// certificate chains to a report collection server.
class CertificateErrorReporter : public net::URLRequest::Delegate {
@@ -44,7 +46,7 @@ class CertificateErrorReporter : public net::URLRequest::Delegate {
~CertificateErrorReporter() override;
- // Construct, serialize, and send a certificate reporter to the report
+ // Construct, serialize, and send a certificate report to the report
// collection server containing the |ssl_info| associated with a
// connection to |hostname|.
virtual void SendReport(ReportType type,
@@ -55,15 +57,19 @@ class CertificateErrorReporter : public net::URLRequest::Delegate {
void OnResponseStarted(net::URLRequest* request) override;
void OnReadCompleted(net::URLRequest* request, int bytes_read) override;
+ protected:
+ enum CookiesPreference { SEND_COOKIES, DO_NOT_SEND_COOKIES };
+
private:
// Create a URLRequest with which to send a certificate report to the
// server.
virtual scoped_ptr<net::URLRequest> CreateURLRequest(
- net::URLRequestContext* context);
+ net::URLRequestContext* context,
+ CookiesPreference cookies_preference);
// Serialize and send a CertLoggerRequest protobuf to the report
// collection server.
- void SendCertLoggerRequest(const CertLoggerRequest& request);
+ void SendCertLoggerRequest(ReportType type, const CertLoggerRequest& request);
// Populate the CertLoggerRequest for a report.
static void BuildReport(const std::string& hostname,

Powered by Google App Engine
This is Rietveld 408576698