Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1060)

Unified Diff: chrome/browser/interstitials/security_interstitial_page.h

Issue 935663004: Add checkbox for reporting invalid TLS/SSL cert chains (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use SecurityInterstitialMetricsHelper for extended reporting events Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/interstitials/security_interstitial_page.h
diff --git a/chrome/browser/interstitials/security_interstitial_page.h b/chrome/browser/interstitials/security_interstitial_page.h
index 0e96ebc1190c7db66f75010513309a2b5c76747b..f6e8915f5563cd31465d7ef4e6305cfe83f540ba 100644
--- a/chrome/browser/interstitials/security_interstitial_page.h
+++ b/chrome/browser/interstitials/security_interstitial_page.h
@@ -5,6 +5,7 @@
#ifndef CHROME_BROWSER_INTERSTITIALS_SECURITY_INTERSTITIAL_PAGE_H_
#define CHROME_BROWSER_INTERSTITIALS_SECURITY_INTERSTITIAL_PAGE_H_
+#include "base/callback.h"
#include "base/strings/string16.h"
#include "content/public/browser/interstitial_page_delegate.h"
#include "url/gurl.h"
@@ -18,6 +19,16 @@ class InterstitialPage;
class WebContents;
}
+namespace interstitials {
+// Constants used to communicate with the JavaScript.
+extern const char kBoxChecked[];
+extern const char kDisplayCheckBox[];
+extern const char kOptInLink[];
+extern const char kPrivacyLinkHtml[];
+}
+
+class SecurityInterstitialMetricsHelper;
+
class SecurityInterstitialPage : public content::InterstitialPageDelegate {
public:
// These represent the commands sent from the interstitial JavaScript.
@@ -51,6 +62,10 @@ class SecurityInterstitialPage : public content::InterstitialPageDelegate {
// Prevents creating the actual interstitial view for testing.
void DontCreateViewForTesting();
+ // Allows tests to be notified when an invalid cert chain report has
+ // been sent (or not sent).
+ void SetCertificateReportCallbackForTesting(const base::Closure& callback);
mattm 2015/03/23 05:31:17 Should be on SSLBlockingPage instead of SecurityIn
estark 2015/03/23 16:42:13 Done.
+
protected:
// Returns true if the interstitial should create a new navigation entry.
virtual bool ShouldCreateNewNavigation() const = 0;
@@ -69,6 +84,24 @@ class SecurityInterstitialPage : public content::InterstitialPageDelegate {
content::WebContents* web_contents() const;
GURL request_url() const;
+ // Record the user's preference for reporting information about
+ // malware and SSL errors.
+ void SetReportingPreference(bool report);
+
+ // Returns the boolean value of the given |pref| from the PrefService of the
+ // Profile associated with |web_contents_|.
+ bool IsPrefEnabled(const char* pref);
+
+ // This callback is run when an extended reporting certificate chain
+ // report has been sent, or when it is decided that it should not be
+ // sent (for example, when in incognito mode).
+ base::Closure certificate_report_callback_for_testing_;
+
+ protected:
+ void OpenExtendedReportingPrivacyPolicy();
+
+ scoped_ptr<SecurityInterstitialMetricsHelper> metrics_helper_;
+
private:
content::WebContents* web_contents_;
const GURL request_url_;

Powered by Google App Engine
This is Rietveld 408576698