Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: chrome/browser/ssl/ssl_blocking_page.h

Issue 935663004: Add checkbox for reporting invalid TLS/SSL cert chains (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix comment typo Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/ssl_blocking_page.h
diff --git a/chrome/browser/ssl/ssl_blocking_page.h b/chrome/browser/ssl/ssl_blocking_page.h
index 4b9b7f184cbf776ee0ef5ea25089b162a256d90f..fd73c85561d22d1510a7884f0243ab3f9e407e88 100644
--- a/chrome/browser/ssl/ssl_blocking_page.h
+++ b/chrome/browser/ssl/ssl_blocking_page.h
@@ -80,6 +80,10 @@ class SSLBlockingPage : public SecurityInterstitialPage {
void PopulateInterstitialStrings(
base::DictionaryValue* load_time_data) override;
+ // SecurityInterstitialPage implementation:
+ void PopulateExtendedReportingOption(
+ base::DictionaryValue* load_time_data) override;
+
private:
void NotifyDenyCertificate();
void NotifyAllowCertificate();
@@ -87,6 +91,10 @@ class SSLBlockingPage : public SecurityInterstitialPage {
std::string GetUmaHistogramPrefix() const;
std::string GetSamplingEventName() const;
+ // Send a report about an invalid certificate to the server. Takes
+ // care of calling certificate_report_callback_for_testing_.
+ void FinishCertCollection();
+
base::Callback<void(bool)> callback_;
const int cert_error_;

Powered by Google App Engine
This is Rietveld 408576698