Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: chrome/browser/net/certificate_error_reporter.cc

Issue 935663004: Add checkbox for reporting invalid TLS/SSL cert chains (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix comment typo Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/certificate_error_reporter.cc
diff --git a/chrome/browser/net/certificate_error_reporter.cc b/chrome/browser/net/certificate_error_reporter.cc
index 57e737fce6d530e8c87fdbab7736527ab0d8a418..d6eada2dbdaec29b8e8cb3adcd987c3180f94c6d 100644
--- a/chrome/browser/net/certificate_error_reporter.cc
+++ b/chrome/browser/net/certificate_error_reporter.cc
@@ -7,6 +7,7 @@
#include <set>
#include "base/logging.h"
+#include "base/memory/weak_ptr.h"
#include "base/stl_util.h"
#include "base/time/time.h"
#include "chrome/browser/net/cert_logger.pb.h"
@@ -20,10 +21,16 @@
namespace chrome_browser_net {
+// URL to upload invalid certificate chain reports
+// TODO(estark): Fill this in with the real URL when live.
+const char kExtendedReportingUploadUrl[] = "http://example.test";
+
CertificateErrorReporter::CertificateErrorReporter(
net::URLRequestContext* request_context,
const GURL& upload_url)
- : request_context_(request_context), upload_url_(upload_url) {
+ : request_context_(request_context),
+ upload_url_(upload_url),
+ weak_ptr_factory_(this) {
DCHECK(!upload_url.is_empty());
}
@@ -72,6 +79,10 @@ void CertificateErrorReporter::OnReadCompleted(net::URLRequest* request,
int bytes_read) {
}
+base::WeakPtr<CertificateErrorReporter> CertificateErrorReporter::GetWeakPtr() {
+ return weak_ptr_factory_.GetWeakPtr();
+}
+
scoped_ptr<net::URLRequest> CertificateErrorReporter::CreateURLRequest(
net::URLRequestContext* context) {
scoped_ptr<net::URLRequest> request =

Powered by Google App Engine
This is Rietveld 408576698