Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4375)

Unified Diff: chrome/browser/net/chrome_fraudulent_certificate_reporter_unittest.cc

Issue 935663004: Add checkbox for reporting invalid TLS/SSL cert chains (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: set callback to DoNothing close to where it's used Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/chrome_fraudulent_certificate_reporter_unittest.cc
diff --git a/chrome/browser/net/chrome_fraudulent_certificate_reporter_unittest.cc b/chrome/browser/net/chrome_fraudulent_certificate_reporter_unittest.cc
index 22dc55f093d546cca86e6bc41b9381d6648195ee..d1c08beaaaf623fa3fca1e1be4603bcc48436ffb 100644
--- a/chrome/browser/net/chrome_fraudulent_certificate_reporter_unittest.cc
+++ b/chrome/browser/net/chrome_fraudulent_certificate_reporter_unittest.cc
@@ -8,6 +8,7 @@
#include "base/bind.h"
#include "base/files/file_path.h"
+#include "base/memory/ref_counted.h"
#include "base/memory/scoped_ptr.h"
#include "base/message_loop/message_loop.h"
#include "base/synchronization/waitable_event.h"
@@ -130,6 +131,7 @@ class MockReporter : public CertificateErrorReporter {
}
private:
+ ~MockReporter() override {}
scoped_ptr<net::URLRequest> CreateURLRequest(
net::URLRequestContext* context) override {
return context->CreateRequest(GURL(std::string()),
@@ -155,8 +157,8 @@ static void DoReportIsNotSent() {
static void DoMockReportIsSent() {
net::TestURLRequestContext context;
- scoped_ptr<MockReporter> error_reporter(new MockReporter(&context));
- ChromeFraudulentCertificateReporter reporter(error_reporter.Pass());
+ scoped_refptr<MockReporter> error_reporter = new MockReporter(&context);
+ ChromeFraudulentCertificateReporter reporter(error_reporter);
SSLInfo info = GetGoodSSLInfo();
reporter.SendReport("mail.google.com", info);
}

Powered by Google App Engine
This is Rietveld 408576698