chrome/browser/net/certificate_error_reporter_unittest.cc - Issue 935663004: Add checkbox for reporting invalid TLS/SSL cert chains

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/certificate_error_reporter_unittest.cc

Issue 935663004: Add checkbox for reporting invalid TLS/SSL cert chains (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: set callback to DoNothing close to where it's used Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/net/certificate_error_reporter.h ('K') | « chrome/browser/net/certificate_error_reporter.cc ('k') | chrome/browser/net/chrome_fraudulent_certificate_reporter.h » ('j') | chrome/browser/resources/security_warnings/ssl.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/net/certificate_error_reporter_unittest.cc

diff --git a/chrome/browser/net/certificate_error_reporter_unittest.cc b/chrome/browser/net/certificate_error_reporter_unittest.cc

index f890f97d5e760d353bd53b7e2184155bfae98f7a..36f60569fa835d974a0514cca4f848f4dd9d9fd5 100644

--- a/chrome/browser/net/certificate_error_reporter_unittest.cc

+++ b/chrome/browser/net/certificate_error_reporter_unittest.cc

@@ -174,12 +174,13 @@ TEST_F(CertificateErrorReporterTest, SendReportSendsRequest) {

GURL url = net::URLRequestMockDataJob::GetMockHttpsUrl("dummy data", 1);

network_delegate()->set_expected_url(url);

- CertificateErrorReporter reporter(context(), url);

+ scoped_refptr<CertificateErrorReporter> reporter =

+ new CertificateErrorReporter(context(), url);

EXPECT_EQ(0, network_delegate()->num_requests());

- reporter.SendReport(CertificateErrorReporter::REPORT_TYPE_PINNING_VIOLATION,

- kHostname, GetTestSSLInfo());

+ reporter->SendReport(CertificateErrorReporter::REPORT_TYPE_PINNING_VIOLATION,

+ kHostname, GetTestSSLInfo());

run_loop.Run();

EXPECT_EQ(1, network_delegate()->num_requests());

@@ -199,11 +200,11 @@ TEST_F(CertificateErrorReporterTest, PendingRequestGetsDeleted) {

EXPECT_EQ(0, network_delegate()->num_requests());

- scoped_ptr<CertificateErrorReporter> reporter(

+ scoped_refptr<CertificateErrorReporter> reporter(

new CertificateErrorReporter(context(), url));

reporter->SendReport(CertificateErrorReporter::REPORT_TYPE_PINNING_VIOLATION,

kHostname, GetTestSSLInfo());

- reporter.reset();

+ reporter = nullptr;

run_loop.Run();

@@ -221,9 +222,10 @@ TEST_F(CertificateErrorReporterTest, ErroredRequestGetsDeleted) {

EXPECT_EQ(0, network_delegate()->num_requests());

- CertificateErrorReporter reporter(context(), url);

- reporter.SendReport(CertificateErrorReporter::REPORT_TYPE_PINNING_VIOLATION,

- kHostname, GetTestSSLInfo());

+ scoped_refptr<CertificateErrorReporter> reporter =

+ new CertificateErrorReporter(context(), url);

+ reporter->SendReport(CertificateErrorReporter::REPORT_TYPE_PINNING_VIOLATION,

+ kHostname, GetTestSSLInfo());

run_loop.Run();

EXPECT_EQ(1, network_delegate()->num_requests());