Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1915)

Unified Diff: chrome/browser/interstitials/security_interstitial_page.cc

Issue 935663004: Add checkbox for reporting invalid TLS/SSL cert chains (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: set callback to DoNothing close to where it's used Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/interstitials/security_interstitial_page.cc
diff --git a/chrome/browser/interstitials/security_interstitial_page.cc b/chrome/browser/interstitials/security_interstitial_page.cc
index 8a72d874ac4729d6840b3fb00d87724872b8447e..12bfe02b78dbc9362b11b505d827c9ea65e768d2 100644
--- a/chrome/browser/interstitials/security_interstitial_page.cc
+++ b/chrome/browser/interstitials/security_interstitial_page.cc
@@ -5,9 +5,13 @@
#include "chrome/browser/interstitials/security_interstitial_page.h"
#include "base/i18n/rtl.h"
+#include "base/metrics/histogram.h"
+#include "base/prefs/pref_service.h"
#include "base/strings/utf_string_conversions.h"
#include "base/values.h"
#include "chrome/browser/browser_process.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/common/pref_names.h"
#include "chrome/grit/browser_resources.h"
#include "content/public/browser/interstitial_page.h"
#include "content/public/browser/web_contents.h"
@@ -15,6 +19,15 @@
#include "ui/base/webui/jstemplate_builder.h"
#include "ui/base/webui/web_ui_util.h"
+namespace interstitials {
+const char kBoxChecked[] = "boxchecked";
+const char kDisplayCheckBox[] = "displaycheckbox";
+const char kOptInLink[] = "optInLink";
+const char kPrivacyLinkHtml[] =
felt 2015/03/13 19:18:11 This needs to be updated, given that https://coder
estark 2015/03/16 23:40:52 Done.
+ "<a id=\"privacy-link\" href=\"\" onclick=\"sendCommand('showPrivacy'); "
+ "return false;\" onmousedown=\"return false;\">%s</a>";
+}
+
SecurityInterstitialPage::SecurityInterstitialPage(
content::WebContents* web_contents,
const GURL& request_url)
@@ -45,6 +58,11 @@ void SecurityInterstitialPage::DontCreateViewForTesting() {
create_view_ = false;
}
+void SecurityInterstitialPage::SetCertificateReportCallbackForTesting(
+ const base::Closure& callback) {
+ certificate_report_callback_for_testing_ = callback;
+}
+
void SecurityInterstitialPage::Show() {
DCHECK(!interstitial_page_);
interstitial_page_ = content::InterstitialPage::Create(
@@ -72,3 +90,17 @@ std::string SecurityInterstitialPage::GetHTMLContents() {
webui::AppendWebUiCssTextDefaults(&html);
return webui::GetI18nTemplateHtml(html, &load_time_data);
}
+
+void SecurityInterstitialPage::SetReportingPreference(bool report) {
+ Profile* profile =
+ Profile::FromBrowserContext(web_contents()->GetBrowserContext());
+ PrefService* pref = profile->GetPrefs();
+ pref->SetBoolean(prefs::kSafeBrowsingExtendedReportingEnabled, report);
+ UMA_HISTOGRAM_BOOLEAN("SB2.SetExtendedReportingEnabled", report);
+}
+
+bool SecurityInterstitialPage::IsPrefEnabled(const char* pref) {
+ Profile* profile =
+ Profile::FromBrowserContext(web_contents()->GetBrowserContext());
+ return profile->GetPrefs()->GetBoolean(pref);
+}

Powered by Google App Engine
This is Rietveld 408576698