Chromium Code Reviews| Index: chrome/browser/safe_browsing/safe_browsing_blocking_page.h |
| diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page.h b/chrome/browser/safe_browsing/safe_browsing_blocking_page.h |
| index 424e516767f21073544df397dcb2e730f8ea38a4..e661ba6143570dec55dd5a271f9ec0d108d78f83 100644 |
| --- a/chrome/browser/safe_browsing/safe_browsing_blocking_page.h |
| +++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page.h |
| @@ -91,7 +91,7 @@ class SafeBrowsingBlockingPage : public SecurityInterstitialPage { |
| friend class SafeBrowsingBlockingPageTest; |
| FRIEND_TEST_ALL_PREFIXES(SafeBrowsingBlockingPageTest, |
| ProceedThenDontProceed); |
| - void SetReportingPreference(bool report); |
| + |
| void UpdateReportingPref(); // Used for the transition from old to new pref. |
| // Don't instantiate this class directly, use ShowBlockingPage instead. |
| @@ -125,10 +125,6 @@ class SafeBrowsingBlockingPage : public SecurityInterstitialPage { |
| // enabled, the report is scheduled to be sent on the |ui_manager_|. |
| void FinishMalwareDetails(int64 delay_ms); |
| - // Returns the boolean value of the given |pref| from the PrefService of the |
| - // Profile associated with |web_contents_|. |
| - bool IsPrefEnabled(const char* pref); |
| - |
| // A list of SafeBrowsingUIManager::UnsafeResource for a tab that the user |
| // should be warned about. They are queued when displaying more than one |
| // interstitial at a time. |
| @@ -186,10 +182,12 @@ class SafeBrowsingBlockingPage : public SecurityInterstitialPage { |
| private: |
| // Fills the passed dictionary with the values to be passed to the template |
| // when creating the HTML. |
| - void PopulateExtendedReportingOption(base::DictionaryValue* load_time_data); |
| void PopulateMalwareLoadTimeData(base::DictionaryValue* load_time_data); |
| void PopulateHarmfulLoadTimeData(base::DictionaryValue* load_time_data); |
| void PopulatePhishingLoadTimeData(base::DictionaryValue* load_time_data); |
| + // SecurityInterstitialPageWithExtendedReporting implementation: |
|
mattm
2015/03/04 02:58:41
I don't see a "SecurityInterstitialPageWithExtende
estark
2015/03/12 22:22:21
Fixed to SecurityInterstitialPage.
|
| + void PopulateExtendedReportingOption( |
| + base::DictionaryValue* load_time_data) override; |
| std::string GetMetricPrefix() const; |
| std::string GetSamplingEventName() const; |