Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: chrome/browser/net/chrome_fraudulent_certificate_reporter.h

Issue 935663004: Add checkbox for reporting invalid TLS/SSL cert chains (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add report-sending callback for browser tests Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/chrome_fraudulent_certificate_reporter.h
diff --git a/chrome/browser/net/chrome_fraudulent_certificate_reporter.h b/chrome/browser/net/chrome_fraudulent_certificate_reporter.h
index c9874768f1e818aeccfa58e670851e2dfc4f55ed..987a485bceb5e4704e5c00bfb76adb84a77f0cd2 100644
--- a/chrome/browser/net/chrome_fraudulent_certificate_reporter.h
+++ b/chrome/browser/net/chrome_fraudulent_certificate_reporter.h
@@ -29,10 +29,12 @@ class ChromeFraudulentCertificateReporter
// Allows users of this class to override this and set their own URLRequest
// type. Used by SendReport.
virtual scoped_ptr<net::URLRequest> CreateURLRequest(
- net::URLRequestContext* context);
+ net::URLRequestContext* context,
+ const GURL& upload_url);
// net::FraudulentCertificateReporter
- void SendReport(const std::string& hostname,
+ void SendReport(ReportType type,
+ const std::string& hostname,
const net::SSLInfo& ssl_info) override;
// net::URLRequest::Delegate
@@ -41,12 +43,13 @@ class ChromeFraudulentCertificateReporter
protected:
net::URLRequestContext* const request_context_;
+ const GURL pinning_violation_upload_url_;
+ const GURL invalid_chain_upload_url_;
private:
// Performs post-report cleanup.
void RequestComplete(net::URLRequest* request);
- const GURL upload_url_;
// Owns the contained requests.
std::set<net::URLRequest*> inflight_requests_;
@@ -56,4 +59,3 @@ class ChromeFraudulentCertificateReporter
} // namespace chrome_browser_net
#endif // CHROME_BROWSER_NET_CHROME_FRAUDULENT_CERTIFICATE_REPORTER_H_
-

Powered by Google App Engine
This is Rietveld 408576698