Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: chrome/browser/ssl/ssl_blocking_page.h

Issue 935663004: Add checkbox for reporting invalid TLS/SSL cert chains (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: felt's comments Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/ssl_blocking_page.h
diff --git a/chrome/browser/ssl/ssl_blocking_page.h b/chrome/browser/ssl/ssl_blocking_page.h
index dac5ab41a2f8050a7f99685cf017b820cde0716b..0ac692c3fc7a83d28ba77be67278441ceddb3bd6 100644
--- a/chrome/browser/ssl/ssl_blocking_page.h
+++ b/chrome/browser/ssl/ssl_blocking_page.h
@@ -28,18 +28,22 @@ class SSLErrorClassification;
// This class is responsible for showing/hiding the interstitial page that is
// shown when a certificate error happens.
// It deletes itself when the interstitial page is closed.
-class SSLBlockingPage : public SecurityInterstitialPage {
+class SSLBlockingPage : public SecurityInterstitialPageWithExtendedReporting {
public:
- // These represent the commands sent from the interstitial JavaScript. They
- // are defined in chrome/browser/resources/ssl/ssl_errors_common.js.
- // DO NOT reorder or change these without also changing the JavaScript!
+ // These represent the commands sent from the interstitial
+ // JavaScript. They are defined in
+ // chrome/browser/resources/security_warnings/ssl_errors_common.js.
+ // DO NOT reorder or change these without also changing the
+ // JavaScript!
enum SSLBlockingPageCommands {
CMD_DONT_PROCEED = 0,
CMD_PROCEED = 1,
CMD_MORE = 2,
CMD_RELOAD = 3,
CMD_HELP = 4,
- CMD_CLOCK = 5
+ CMD_CLOCK = 5,
+ CMD_DO_REPORT = 6,
+ CMD_DONT_REPORT = 7
};
enum SSLBlockingPageOptionsMask {
@@ -91,6 +95,10 @@ class SSLBlockingPage : public SecurityInterstitialPage {
void PopulateInterstitialStrings(
base::DictionaryValue* load_time_data) override;
+ // SecurityInterstitialPageWithExtendedReporting implementation:
+ void PopulateExtendedReportingOption(
+ base::DictionaryValue* load_time_data) override;
+
private:
void NotifyDenyCertificate();
void NotifyAllowCertificate();
@@ -98,6 +106,8 @@ class SSLBlockingPage : public SecurityInterstitialPage {
std::string GetUmaHistogramPrefix() const;
std::string GetSamplingEventName() const;
+ void FinishCertCollection();
+
base::Callback<void(bool)> callback_;
const int cert_error_;

Powered by Google App Engine
This is Rietveld 408576698