Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5068)

Unified Diff: chrome/browser/interstitials/security_interstitial_page.h

Issue 935663004: Add checkbox for reporting invalid TLS/SSL cert chains (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add test for not sending reports when flag is disabled Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/interstitials/security_interstitial_page.h
diff --git a/chrome/browser/interstitials/security_interstitial_page.h b/chrome/browser/interstitials/security_interstitial_page.h
index 98e8e197eeb6f766f42631fe9c890f1764e0ca36..7f20ae6388a2c8eb110710f3e4dfc01035bb21a5 100644
--- a/chrome/browser/interstitials/security_interstitial_page.h
+++ b/chrome/browser/interstitials/security_interstitial_page.h
@@ -51,6 +51,19 @@ class SecurityInterstitialPage : public content::InterstitialPageDelegate {
content::WebContents* web_contents() const;
GURL request_url() const;
+ // Record the user's preference for reporting information about
+ // malware and SSL errors.
+ void SetReportingPreference(bool report);
+
+ // Fills the passed dictionary with the values to be passed to the template
+ // when creating the HTML.
+ virtual void PopulateExtendedReportingOption(
+ base::DictionaryValue* load_time_data) = 0;
+
+ // Returns the boolean value of the given |pref| from the PrefService of the
+ // Profile associated with |web_contents_|.
+ bool IsPrefEnabled(const char* pref);
+
private:
content::WebContents* web_contents_;
const GURL request_url_;
@@ -63,4 +76,11 @@ class SecurityInterstitialPage : public content::InterstitialPageDelegate {
DISALLOW_COPY_AND_ASSIGN(SecurityInterstitialPage);
};
+namespace interstitials {
felt 2015/02/24 01:57:53 nit: I feel like this should be above the class de
estark 2015/02/24 18:47:08 Done -- there are other |namespace {...}|s up ther
+// Constants used to communicate with the JavaScript.
+extern const char kBoxChecked[];
+extern const char kDisplayCheckBox[];
+extern const char kPrivacyLinkHtml[];
+}
+
#endif // CHROME_BROWSER_INTERSTITIALS_SECURITY_INTERSTITIAL_PAGE_H_

Powered by Google App Engine
This is Rietveld 408576698