Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: chrome/browser/net/certificate_error_reporter_unittest.cc

Issue 935663004: Add checkbox for reporting invalid TLS/SSL cert chains (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: revert accidental deletion (fixes failing CaptivePortal tests) Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/certificate_error_reporter_unittest.cc
diff --git a/chrome/browser/net/certificate_error_reporter_unittest.cc b/chrome/browser/net/certificate_error_reporter_unittest.cc
index 1647776df9ecaf9a52e90e4fcd475d0ec2274b1e..843050d19349978ca2e941dfa4c33b161bd02b3f 100644
--- a/chrome/browser/net/certificate_error_reporter_unittest.cc
+++ b/chrome/browser/net/certificate_error_reporter_unittest.cc
@@ -201,7 +201,8 @@ void SendReport(TestCertificateErrorReporterNetworkDelegate* network_delegate,
network_delegate->set_expected_url(url);
network_delegate->ExpectHostname(report_hostname);
- CertificateErrorReporter reporter(context, url);
+ CertificateErrorReporter reporter(
+ context, url, CertificateErrorReporter::DO_NOT_SEND_COOKIES);
EXPECT_EQ(request_sequence_number, network_delegate->num_requests());
@@ -235,7 +236,8 @@ TEST_F(CertificateErrorReporterTest, SendMultipleReportsSimultaneously) {
network_delegate()->ExpectHostname(kHostname);
network_delegate()->ExpectHostname(kSecondRequestHostname);
- CertificateErrorReporter reporter(context(), url);
+ CertificateErrorReporter reporter(
+ context(), url, CertificateErrorReporter::DO_NOT_SEND_COOKIES);
EXPECT_EQ(0, network_delegate()->num_requests());
@@ -264,8 +266,8 @@ TEST_F(CertificateErrorReporterTest, PendingRequestGetsDeleted) {
EXPECT_EQ(0, network_delegate()->num_requests());
- scoped_ptr<CertificateErrorReporter> reporter(
- new CertificateErrorReporter(context(), url));
+ scoped_ptr<CertificateErrorReporter> reporter(new CertificateErrorReporter(
+ context(), url, CertificateErrorReporter::DO_NOT_SEND_COOKIES));
reporter->SendReport(CertificateErrorReporter::REPORT_TYPE_PINNING_VIOLATION,
kHostname, GetTestSSLInfo());
reporter.reset();
« no previous file with comments | « chrome/browser/net/certificate_error_reporter.cc ('k') | chrome/browser/net/chrome_fraudulent_certificate_reporter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698