Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3937)

Unified Diff: chrome/browser/net/certificate_error_reporter.h

Issue 935663004: Add checkbox for reporting invalid TLS/SSL cert chains (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: revert accidental deletion (fixes failing CaptivePortal tests) Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/certificate_error_reporter.h
diff --git a/chrome/browser/net/certificate_error_reporter.h b/chrome/browser/net/certificate_error_reporter.h
index 5463d5a74bd69d6286bbb8cbe1115fc78e8bcd41..e14f7659eab508a5cbf12a8abd8cc116a5299a08 100644
--- a/chrome/browser/net/certificate_error_reporter.h
+++ b/chrome/browser/net/certificate_error_reporter.h
@@ -36,15 +36,21 @@ class CertificateErrorReporter : public net::URLRequest::Delegate {
REPORT_TYPE_EXTENDED_REPORTING
};
+ // Represents whether or not to send cookies along with reports sent
+ // to the server.
+ enum CookiesPreference { SEND_COOKIES, DO_NOT_SEND_COOKIES };
+
// Create a certificate error reporter that will send certificate
// error reports to |upload_url|, using |request_context| as the
- // context for the reports.
+ // context for the reports. |cookies_preference| controls whether
+ // cookies will be sent along with the reports.
CertificateErrorReporter(net::URLRequestContext* request_context,
- const GURL& upload_url);
+ const GURL& upload_url,
+ CookiesPreference cookies_preference);
~CertificateErrorReporter() override;
- // Construct, serialize, and send a certificate reporter to the report
+ // Construct, serialize, and send a certificate report to the report
// collection server containing the |ssl_info| associated with a
// connection to |hostname|.
virtual void SendReport(ReportType type,
@@ -79,6 +85,8 @@ class CertificateErrorReporter : public net::URLRequest::Delegate {
// Owns the contained requests.
std::set<net::URLRequest*> inflight_requests_;
+ CookiesPreference cookies_preference_;
+
DISALLOW_COPY_AND_ASSIGN(CertificateErrorReporter);
};
« no previous file with comments | « chrome/browser/interstitials/security_interstitial_page.cc ('k') | chrome/browser/net/certificate_error_reporter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698