 Chromium Code Reviews
 Chromium Code Reviews Issue 935663004:
  Add checkbox for reporting invalid TLS/SSL cert chains  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 935663004:
  Add checkbox for reporting invalid TLS/SSL cert chains  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: chrome/browser/safe_browsing/ui_manager.h | 
| diff --git a/chrome/browser/safe_browsing/ui_manager.h b/chrome/browser/safe_browsing/ui_manager.h | 
| index 543b1ab57284dfde1d7d3d16d439a511981e2625..3c434a0d2fdd310f01824ce4db1fd82aa4960919 100644 | 
| --- a/chrome/browser/safe_browsing/ui_manager.h | 
| +++ b/chrome/browser/safe_browsing/ui_manager.h | 
| @@ -26,6 +26,10 @@ namespace base { | 
| class Thread; | 
| } | 
| +namespace net { | 
| +class SSLInfo; | 
| +} | 
| 
Ryan Sleevi
2015/03/25 04:49:46
both this and line 27 should have the boilerplate
 
estark
2015/03/25 05:34:33
Done.
 | 
| + | 
| // Construction needs to happen on the main thread. | 
| class SafeBrowsingUIManager | 
| : public base::RefCountedThreadSafe<SafeBrowsingUIManager> { | 
| 
Ryan Sleevi
2015/03/25 04:49:46
Not your fault, but this raises red flags for me o
 
estark
2015/03/25 05:34:33
Acknowledged.
 | 
| @@ -124,6 +128,12 @@ class SafeBrowsingUIManager | 
| SBThreatType threat_type, | 
| const std::string& post_data); | 
| + // Report an invalid TLS/SSL certificate chain to the server. Can only | 
| + // be called on UI thread. | 
| + void ReportInvalidCertificateChain(const std::string& hostname, | 
| + const net::SSLInfo& ssl_info, | 
| + const base::Closure& callback); | 
| + | 
| // Add and remove observers. These methods must be invoked on the UI thread. | 
| void AddObserver(Observer* observer); | 
| void RemoveObserver(Observer* remove); | 
| @@ -145,6 +155,10 @@ class SafeBrowsingUIManager | 
| SBThreatType threat_type, | 
| const std::string& post_data); | 
| + // Sends an invalid certificate chain report over the network. | 
| + void ReportInvalidCertificateChainOnIOThread(const std::string& hostname, | 
| + const net::SSLInfo& ssl_info); | 
| + | 
| // Adds the given entry to the whitelist. Called on the UI thread. | 
| void UpdateWhitelist(const UnsafeResource& resource); |