chrome/browser/net/chrome_fraudulent_certificate_reporter_unittest.cc - Issue 935663004: Add checkbox for reporting invalid TLS/SSL cert chains

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/chrome_fraudulent_certificate_reporter_unittest.cc

Issue 935663004: Add checkbox for reporting invalid TLS/SSL cert chains (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: also record when users disable extended reporting Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/net/certificate_error_reporter.cc ('K') | « chrome/browser/net/chrome_fraudulent_certificate_reporter.cc ('k') | chrome/browser/resources/security_warnings/extended_reporting.js » ('j') | chrome/browser/resources/security_warnings/extended_reporting.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/net/chrome_fraudulent_certificate_reporter_unittest.cc

diff --git a/chrome/browser/net/chrome_fraudulent_certificate_reporter_unittest.cc b/chrome/browser/net/chrome_fraudulent_certificate_reporter_unittest.cc

index 22dc55f093d546cca86e6bc41b9381d6648195ee..3f9a3acbd28d13f4f117ad620f206924f1171a0c 100644

--- a/chrome/browser/net/chrome_fraudulent_certificate_reporter_unittest.cc

+++ b/chrome/browser/net/chrome_fraudulent_certificate_reporter_unittest.cc

@@ -118,7 +118,10 @@ class NotSendingTestReporter : public TestReporter {

class MockReporter : public CertificateErrorReporter {

public:

explicit MockReporter(net::URLRequestContext* request_context)

- : CertificateErrorReporter(request_context, GURL("http://example.com")) {}

+ : CertificateErrorReporter(

+ request_context,

+ GURL("http://example.com"),

+ CertificateErrorReporter::DO_NOT_SEND_COOKIES) {}

void SendReport(ReportType type,

const std::string& hostname,