chrome/browser/chrome_content_browser_client.cc - Issue 935663004: Add checkbox for reporting invalid TLS/SSL cert chains

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 935663004: Add checkbox for reporting invalid TLS/SSL cert chains (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix histograms typo, other cleanup Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/browser/interstitials/security_interstitial_metrics_helper.h » ('j') | chrome/browser/net/certificate_error_reporter.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chrome_content_browser_client.cc

diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc

index f3d767f5790f955d8df52b54a1ce038bf0a7c366..97425a07d6445ee8265f4a56cabc381b8a1817ed 100644

--- a/chrome/browser/chrome_content_browser_client.cc

+++ b/chrome/browser/chrome_content_browser_client.cc

@@ -60,6 +60,7 @@

#include "chrome/browser/push_messaging/push_messaging_permission_context_factory.h"

#include "chrome/browser/renderer_host/chrome_render_message_filter.h"

#include "chrome/browser/renderer_host/pepper/chrome_browser_pepper_host_factory.h"

+#include "chrome/browser/safe_browsing/safe_browsing_service.h"

#include "chrome/browser/search/instant_service.h"

#include "chrome/browser/search/instant_service_factory.h"

#include "chrome/browser/search/search.h"

@@ -1785,8 +1786,13 @@ void ChromeContentBrowserClient::AllowCertificateError(

if (expired_previous_decision)

options_mask |= SSLBlockingPage::EXPIRED_BUT_PREVIOUSLY_ALLOWED;

+ SafeBrowsingService* safe_browsing_service =

+ g_browser_process->safe_browsing_service();

SSLErrorHandler::HandleSSLError(

- tab, cert_error, ssl_info, request_url, options_mask, callback);

+ tab, cert_error, ssl_info, request_url, options_mask,

+ safe_browsing_service ? safe_browsing_service->ui_manager().get()

+ : nullptr,

+ callback);

}

void ChromeContentBrowserClient::SelectClientCertificate(