Add checkbox for reporting invalid TLS/SSL cert chains

chrome/browser/profiles/profile_io_data.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_io_data.h"
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/bind.h"
@@ skipping 17 matching lines @@
 #include "chrome/browser/content_settings/cookie_settings.h"
 #include "chrome/browser/custom_handlers/protocol_handler_registry.h"
 #include "chrome/browser/custom_handlers/protocol_handler_registry_factory.h"
 #include "chrome/browser/devtools/devtools_network_controller.h"
 #include "chrome/browser/devtools/devtools_network_transaction_factory.h"
 #include "chrome/browser/download/download_service.h"
 #include "chrome/browser/download/download_service_factory.h"
 #include "chrome/browser/io_thread.h"
 #include "chrome/browser/media/media_device_id_salt.h"
 #include "chrome/browser/net/about_protocol_handler.h"
+#include "chrome/browser/net/certificate_error_reporter.h"
 #include "chrome/browser/net/chrome_fraudulent_certificate_reporter.h"
 #include "chrome/browser/net/chrome_http_user_agent_settings.h"
 #include "chrome/browser/net/chrome_net_log.h"
 #include "chrome/browser/net/chrome_network_delegate.h"
 #include "chrome/browser/net/chrome_url_request_context_getter.h"
 #include "chrome/browser/net/cookie_store_util.h"
 #include "chrome/browser/net/proxy_service_factory.h"
 #include "chrome/browser/net/resource_prefetch_predictor_observer.h"
 #include "chrome/browser/predictors/resource_prefetch_predictor.h"
 #include "chrome/browser/predictors/resource_prefetch_predictor_factory.h"
@@ skipping 29 matching lines @@
 #include "net/ssl/client_cert_store.h"
 #include "net/url_request/data_protocol_handler.h"
 #include "net/url_request/file_protocol_handler.h"
 #include "net/url_request/ftp_protocol_handler.h"
 #include "net/url_request/url_request.h"
 #include "net/url_request/url_request_context.h"
 #include "net/url_request/url_request_file_job.h"
 #include "net/url_request/url_request_intercepting_job_factory.h"
 #include "net/url_request/url_request_interceptor.h"
 #include "net/url_request/url_request_job_factory_impl.h"
+#include "url/gurl.h"
 
 #if defined(ENABLE_CONFIGURATION_POLICY)
 #include "chrome/browser/policy/cloud/policy_header_service_factory.h"
 #include "chrome/browser/policy/policy_helpers.h"
 #include "components/policy/core/browser/url_blacklist_manager.h"
 #include "components/policy/core/common/cloud/policy_header_io_helper.h"
 #include "components/policy/core/common/cloud/policy_header_service.h"
 #include "components/policy/core/common/cloud/user_cloud_policy_manager.h"
 #endif
 
@@ skipping 45 matching lines @@
 #endif
 
 #if defined(OS_WIN)
 #include "net/ssl/client_cert_store_win.h"
 #endif
 
 #if defined(OS_MACOSX)
 #include "net/ssl/client_cert_store_mac.h"
 #endif
 
+using chrome_browser_net::CertificateErrorReporter;
 using content::BrowserContext;
 using content::BrowserThread;
 using content::ResourceContext;
 
 namespace {
 
 #if defined(DEBUG_DEVTOOLS)
 bool IsSupportedDevToolsURL(const GURL& url, base::FilePath* path) {
   std::string bundled_path_prefix(chrome::kChromeUIDevToolsBundledPath);
   bundled_path_prefix = "/" + bundled_path_prefix + "/";
@@ skipping 716 matching lines @@
 
 bool ProfileIOData::GetMetricsEnabledStateOnIOThread() const {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
 #if defined(OS_CHROMEOS)
   return enable_metrics_;
 #else
   return enable_metrics_.GetValue();
 #endif  // defined(OS_CHROMEOS)
 }
 
+void ProfileIOData::set_certificate_error_reporter_for_testing(
+    chrome_browser_net::CertificateErrorReporter* certificate_error_reporter) {
+  certificate_error_reporter_.reset(certificate_error_reporter);
+}
+
 bool ProfileIOData::IsDataReductionProxyEnabled() const {
   return data_reduction_proxy_io_data()->IsEnabled();
 }
 
+base::WeakPtr<CertificateErrorReporter>
+ProfileIOData::certificate_error_reporter() const {
+  return certificate_error_reporter_->GetWeakPtr();
+}
+
 void ProfileIOData::set_data_reduction_proxy_io_data(
     scoped_ptr<data_reduction_proxy::DataReductionProxyIOData>
         data_reduction_proxy_io_data) const {
   data_reduction_proxy_io_data_ = data_reduction_proxy_io_data.Pass();
 }
 
 base::WeakPtr<net::HttpServerProperties>
 ProfileIOData::http_server_properties() const {
   return http_server_properties_->GetWeakPtr();
 }
@@ skipping 151 matching lines @@
   network_delegate->set_profile(profile_params_->profile);
   network_delegate->set_profile_path(profile_params_->path);
   network_delegate->set_cookie_settings(profile_params_->cookie_settings.get());
   network_delegate->set_enable_do_not_track(&enable_do_not_track_);
   network_delegate->set_force_safe_search(&force_safesearch_);
   network_delegate->set_force_google_safe_search(&force_google_safesearch_);
   network_delegate->set_force_youtube_safety_mode(&force_youtube_safety_mode_);
   fraudulent_certificate_reporter_.reset(
       new chrome_browser_net::ChromeFraudulentCertificateReporter(
           main_request_context_.get()));
+  certificate_error_reporter_.reset(new CertificateErrorReporter(
+      main_request_context_.get(),

[mattm, 2015/03/17 20:58:12]

If these are going to be handled by safebrowsing servers as felt said, this
should probably be using the safebrowsing_url_request_context...
Actually if that's the case, sending the report could just be a method on
SafeBrowsingPingManager, rather than needing a separate CertificateErrorReporter
class and finding something to own it, etc.

[estark, 2015/03/17 21:26:15]

Could SafeBrowsingPingManager be the thing that owns the reporter object? I
think we still need a separate CertificateErrorReporter class, because it is
used to implement ChromeFraudulentCertificateReporter.

[mattm, 2015/03/17 23:57:51]

I suppose, yeah.

Oh, I forgot to mention, with using the SafeBrowsingRequestContext and talking
to safebrowsing servers, you'd want to have cookies enabled.

[estark, 2015/03/18 15:57:18]

Done.
Could you point me to an example of how to do that (enable cookies)?

[mattm, 2015/03/23 05:31:17]

Just need to remove the LOAD_DO_NOT_SEND_COOKIES and LOAD_DO_NOT_SAVE_COOKIES
from the load flags.

[felt, 2015/03/23 14:04:32]

Hold up real quick -- what are the implications of enabling cookies? Are there
privacy implications of this? Why are cookies needed?

[estark, 2015/03/23 20:55:28]

Done.

I think I should add unit tests that CertificateErrorReporter sends cookies on
REPORT_TYPE_EXTENDED_REPORTING reports and not on other reports, but I have to
figure how to do that and I'd like to do it in a follow-up CL, if that's okay.

+      GURL(chrome_browser_net::kExtendedReportingUploadUrl)));
 
   // TODO(vadimt): Remove ScopedTracker below once crbug.com/436671 is fixed.
   tracked_objects::ScopedTracker tracking_profile3(
       FROM_HERE_WITH_EXPLICIT_FUNCTION("436671 ProfileIOData::Init3"));
 
   // NOTE: Proxy service uses the default io thread network delegate, not the
   // delegate just created.
   proxy_service_.reset(
       ProxyServiceFactory::CreateProxyService(
           io_thread->net_log(),
@@ skipping 269 matching lines @@
 void ProfileIOData::SetCookieSettingsForTesting(
     CookieSettings* cookie_settings) {
   DCHECK(!cookie_settings_.get());
   cookie_settings_ = cookie_settings;
 }
 
 void ProfileIOData::set_signin_names_for_testing(
     SigninNamesOnIOThread* signin_names) {
   signin_names_.reset(signin_names);
 }